Skip to content

Commit 96a8f2b

Browse files
committed
Check 192 address is private in CI 2
1 parent b1465f3 commit 96a8f2b

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

app/validators/http_url_validator.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@ def accessible?(value)
1515
code = res.code
1616
end
1717
end
18-
rescue PrivateAddressCheck::PrivateConnectionAttemptedError
18+
rescue PrivateAddressCheck::PrivateConnectionAttemptedError => e
19+
pp e.class.name
1920
return false
2021
rescue Net::OpenTimeout, Net::ReadTimeout, SocketError,
21-
Errno::ECONNREFUSED, Errno::EHOSTUNREACH, OpenSSL::SSL::SSLError, URI::InvalidURIError
22+
Errno::ECONNREFUSED, Errno::EHOSTUNREACH, OpenSSL::SSL::SSLError, URI::InvalidURIError => e
23+
pp e.class.name
2224
code = 999
2325
end
2426
options[:allow_inaccessible] || code == 200

test/models/profile_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ class ProfileTest < ActiveSupport::TestCase
8484
# private address is not OK
8585
WebMock.allow_net_connect!
8686
assert PrivateAddressCheck.resolves_to_private_address?('192.168.0.1')
87+
puts '?'
8788
VCR.turned_off do
8889
refute profile.update(website: 'http://192.168.0.1')
8990
assert profile.errors.added?(:website, 'is not accessible')

0 commit comments

Comments
 (0)