Check & handle actual value types coming from icalendar gem

According to: https://github.com/icalendar/icalendar/blob/v2.12.2/lib/icalendar/event.rb

Author: fbacall

lib/ingestors/event_ingestion.rb

@@ -29,10 +29,6 @@ def convert_event_types(input)
       EventTypeDictionary.instance.lookup_value(input, 'title')
     end
 
-    def convert_location(input)
-      input
-    end
-
     def parse_dates(input, timezone = nil)
       Time.use_zone(timezone) do
         # try to split on obvious interval markers

lib/ingestors/ical_ingestor.rb

@@ -38,61 +38,41 @@ def process_icalendar(url)
         events = Icalendar::Event.parse(data.set_encoding('utf-8'))
 
         # process each event
-        events.each do |e|
-          process_event(e)
+        events.each do |ical_event|
+          add_event(process_event(ical_event))
         end
       end
       # finished
     end
 
     def process_event(calevent)
-      # puts "calevent: #{calevent.inspect}"
       # set fields
       event = OpenStruct.new
-      event.url = calevent.url.to_s
-      event.title = calevent.summary.to_s
-      event.description = process_description calevent.description
-
-      # puts "\n\ncalevent.description = #{calevent.description}"
-      # puts "\n\n...        converted = #{event.description}"
+      event.url = calevent.url&.to_s
+      event.title = calevent.summary&.to_s
+      event.description = process_description(calevent.description)
 
       event.end = calevent.dtend&.to_time
       unless calevent.dtstart.nil?
         dtstart = calevent.dtstart
         event.start = dtstart&.to_time
         tzid = dtstart.ical_params['tzid']
-        event.timezone = tzid.first.to_s if !tzid.nil? and tzid.size > 0
+        event.timezone = tzid.first.to_s if tzid.present?
       end
 
-      event.venue = calevent.location.to_s
-      if calevent.location.downcase.include?('online')
-        event.online = true
-        event.city = nil
-        event.postcode = nil
-        event.country = nil
-      else
-        location = convert_location(calevent.location)
-        event.city = location['suburb'] unless location['suburb'].nil?
-        event.country = location['country'] unless location['country'].nil?
-        event.postcode = location['postcode'] unless location['postcode'].nil?
-      end
-      event.keywords = []
-      unless calevent.categories.nil? or calevent.categories.first.nil?
-        cats = calevent.categories.first
-        if cats.is_a?(Icalendar::Values::Helpers::Array)
-          cats.each do |item|
-            event.keywords << item.to_s.lstrip
-          end
-        else
-          event.keywords << cats.to_s.strip
+      if calevent.location
+        event.venue = calevent.location.to_s
+        if calevent.location.downcase.include?('online')
+          event.online = true
+          event.city = nil
+          event.postcode = nil
+          event.country = nil
         end
       end
 
-      # store event
-      @events << event
+      event.keywords = calevent.categories.flatten.map(&:strip)
 
-      # finished
-      nil
+      event
     end
 
     def process_description(input)