Ensure ORCIDs in test code are valid

Author: fbacall

test/controllers/materials_controller_test.rb

@@ -1620,14 +1620,14 @@ class MaterialsControllerTest < ActionController::TestCase
 
   test 'should display material authors/contributors appropriately' do
     assert @material.update(authors: [{ name: 'John Doe' },
-                                      { name: 'Jane Smith', orcid: '0000-0002-1234-5678' }],
+                                      { name: 'Jane Smith', orcid: '0000-0001-9999-9990' }],
                             contributors: [{ name: 'Jos Ca', orcid: '0000-0002-1825-0097' }])
 
     get :show, params: { id: @material.id }
 
     assert_select '.authors', text: 'Authors: John Doe, Jane Smith'
     assert_select '.authors a', count: 1 do
-      assert_select '[href=?]', 'https://orcid.org/0000-0002-1234-5678'
+      assert_select '[href=?]', 'https://orcid.org/0000-0001-9999-9990'
     end
 
     assert_select '.contributors', { text: 'Contributors: Josiah Carberry' },

test/models/material_test.rb

@@ -158,7 +158,7 @@ class MaterialTest < ActiveSupport::TestCase
 
   test 'should set authors from array of hashes' do
     @material.authors = [
-      { name: 'John Doe', orcid: '0000-0001-1234-5678' },
+      { name: 'John Doe', orcid: '0000-0002-1825-0097' },
       { name: 'Jane Smith' }
     ]
     @material.save!
@@ -241,7 +241,7 @@ class MaterialTest < ActiveSupport::TestCase
 
   test 'should set contributors from array of hashes' do
     @material.contributors = [
-      { name: 'John Doe', orcid: '0000-0001-1234-5678' },
+      { name: 'John Doe', orcid: '0000-0002-1825-0097' },
       { name: 'Jane Smith' }
     ]
     @material.save!

test/models/person_test.rb

@@ -57,7 +57,7 @@ class PersonTest < ActiveSupport::TestCase
   end
 
   test 'should not link to profile if no matching orcid' do
-    person = @material.authors.create(name: 'John Doe', orcid: '0000-0001-9999-9999')
+    person = @material.authors.create(name: 'John Doe', orcid: '0000-0001-9999-9990')
     assert person.valid?
     assert_nil person.profile
   end