test(indico_ingestor): added tests

kennethrioja · kennethrioja · commit ab659e0f95c8 · 2025-12-08T17:25:57.000+01:00
diff --git a/lib/ingestors/indico_ingestor.rb b/lib/ingestors/indico_ingestor.rb
@@ -106,7 +106,7 @@ def assign_basic_info(event, calevent)
       event.url = calevent.url.to_s
       event.title = calevent.summary.to_s
       event.description = calevent.description.to_s
-      event.keywords = process_keywords(calevent.categories)
+      event.keywords = calevent.categories.flatten
       event.contact = calevent.contact.join(', ')
     end
 
@@ -125,7 +125,6 @@ def assign_location_info(event, calevent)
       event.venue = location.to_s
       event.online = calevent.description.include?('zoom')
       event.presence = calevent.description.include?('zoom') ? :hybrid : :onsite # can do best, but sufficient for now
-      event.city, event.postcode, event.country = process_location(location)
     end
 
     # Extracts the timezone identifier (TZID) from an iCalendar event's dtstart field.
@@ -138,20 +137,5 @@ def get_tzid(dtstart)
 
       tzid.is_a?(Array) ? tzid.first.to_s : tzid.to_s
     end
-
-    # Returns an array of 3 location characteristics: suburb, postcode, country
-    # Everything is nil if location.blank or location is online
-    def process_location(location)
-      return [location['suburb'], location['postcode'], location['country']] if location.is_a?(Array)
-
-      [nil, nil, nil]
-    end
-
-    # Returns keywords from the `CATEGORIES` ICal field
-    def process_keywords(categories)
-      return [] if categories.blank?
-
-      categories.flatten.compact.map { |cat| cat.to_s.strip }
-    end
   end
 end
diff --git a/test/fixtures/files/ingestion/indico/event.ics b/test/fixtures/files/ingestion/indico/event.ics
@@ -0,0 +1,16 @@
+BEGIN:VCALENDAR
+VERSION:2.0
+PRODID:-//CERN//INDICO//EN
+BEGIN:VEVENT
+SUMMARY:14th HEP C++ Course and Hands-on Training - The Essentials
+DTSTART:20260309T080000Z
+DTEND:20260313T161500Z
+DTSTAMP:20251204T105300Z
+UID:indico-event-1617123@indico.cern.ch
+CONTACT:name.surname@test.com
+DESCRIPTION:speakers and zoom here
+LOCATION:CERN
+URL:https://indico.cern.ch/event/1617123/
+CATEGORIES:TRAINING,EDUCATION
+END:VEVENT
+END:VCALENDAR
diff --git a/test/fixtures/files/ingestion/indico/events.ics b/test/fixtures/files/ingestion/indico/events.ics
@@ -0,0 +1,25 @@
+BEGIN:VCALENDAR
+VERSION:2.0
+PRODID:-//CERN//INDICO//EN
+BEGIN:VEVENT
+SUMMARY:14th HEP C++ Course and Hands-on Training - The Essentials
+DTSTART:20260309T080000Z
+DTEND:20260313T161500Z
+DTSTAMP:20251203T150800Z
+UID:indico-event-1617123@indico.cern.ch
+CONTACT:name.surname@test.com
+DESCRIPTION:speakers and zoom here
+LOCATION:CERN
+URL:https://indico.cern.ch/event/1617123/
+END:VEVENT
+BEGIN:VEVENT
+SUMMARY:HEP C++ Course and Hands-on Training - Stay Informed
+DTSTART:20991231T225800Z
+DTEND:20991231T225900Z
+DTSTAMP:20251203T150800Z
+UID:indico-event-1211412@indico.cern.ch
+CONTACT:name.surname@test.com
+DESCRIPTION:mockdescription
+URL:https://indico.cern.ch/event/1211412/
+END:VEVENT
+END:VCALENDAR
diff --git a/test/fixtures/files/ingestion/indico/indico.html b/test/fixtures/files/ingestion/indico/indico.html
@@ -0,0 +1,16 @@
+<!DOCTYPE html>
+
+<html lang="en"
+      data-canonical-locale="en-US"
+      data-static-site="false">
+<head>
+    <title>My Agenda (Indico)</title>
+    <meta charset="UTF-8">
+    <meta http-equiv="X-UA-Compatible" content="IE=edge">
+    <link rel="shortcut icon" type="image/x-icon" href="/images/indico.ico">
+
+    <meta property="og:site_name" content="Agenda (Indico)">
+    <meta property="og:image" content="https://agenda.com/images/indico_square.png">
+    
+</head>
+</html>
diff --git a/test/unit/ingestors/indico_ingestor_test.rb b/test/unit/ingestors/indico_ingestor_test.rb
