Skip to content

Commit afd6d1d

Browse files
committed
calculate 2 week grace period from end instead of start
1 parent 5688a78 commit afd6d1d

6 files changed

Lines changed: 77 additions & 19 deletions

File tree

lib/ingestors/taxila/dcc_ingestor.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def process_dcc(url)
4141
event.start = Time.zone.parse(start_str[0])
4242
event.end = Time.zone.parse(start_str[1])
4343
end
44-
if event.start < Time.zone.now - 2.weeks
44+
if event.end < Time.zone.now - 2.weeks
4545
event.start = event.start.change(year: Time.now.year + 1)
4646
event.end = event.end.change(year: Time.now.year + 1)
4747
end

lib/ingestors/taxila/lcrdm_ingestor.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def process_lcrdm(url)
4545
elsif [2, 3].include?(split_time_str[1].split(' ').length)
4646
event.end = Time.zone.parse(split_time_str[1])
4747
end
48-
if event.start < Time.zone.now - 2.weeks
48+
if event.end < Time.zone.now - 2.weeks
4949
event.start = event.start.change(year: Time.now.year + 1)
5050
event.end = event.end.change(year: Time.now.year + 1)
5151
end

lib/ingestors/taxila/oscd_ingestor.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def oscd_fix_time(date_str)
7171

7272
event_start = Time.zone.parse([el1, el2].join(' '))
7373
event_end = Time.zone.parse([el1, el2].join(' '))
74-
if event_start < (Time.zone.now - 2.weeks)
74+
if event_end < (Time.zone.now - 2.weeks)
7575
event_start = event_start.change(year: event_start.year + 1)
7676
event_end = event_end.change(year: event_start.year + 1)
7777
end

lib/ingestors/taxila/rdnl_ingestor.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def process_rdnl(url)
4444
end
4545
event.start = event.start.change(year: event.end.year) if event.start < event.end - 1.year
4646
event.start = event.start.change(year: event.end.year - 1) if event.start > event.end
47-
if event.start < Time.zone.now - 2.weeks
47+
if event.end < Time.zone.now - 2.weeks
4848
event.start = event.start.change(year: Time.now.year + 1)
4949
event.end = event.end.change(year: Time.now.year + 1)
5050
end

test/unit/ingestors/taxila/rdnl_ingestor_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class RDNLIngestorTest < ActiveSupport::TestCase
2727
refute Event.where(title: new_title, url: new_url).any?
2828

2929
# run task
30-
assert_difference 'Event.count', 2 do
30+
assert_difference 'Event.count', 3 do
3131
freeze_time(2026) do
3232
VCR.use_cassette('ingestors/rdnl') do
3333
ingestor.read(source.url)
@@ -36,9 +36,9 @@ class RDNLIngestorTest < ActiveSupport::TestCase
3636
end
3737
end
3838

39-
assert_equal 2, ingestor.events.count
39+
assert_equal 3, ingestor.events.count
4040
assert ingestor.materials.empty?
41-
assert_equal 2, ingestor.stats[:events][:added]
41+
assert_equal 3, ingestor.stats[:events][:added]
4242
assert_equal 0, ingestor.stats[:events][:updated]
4343
assert_equal 0, ingestor.stats[:events][:rejected]
4444

test/vcr_cassettes/ingestors/rdnl.yml

Lines changed: 70 additions & 12 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)