Make cross-space facet usable by anyone

Author: fbacall

app/views/search/common/_facet_sidebar.html.erb

@@ -52,6 +52,13 @@ Variable that should be available
     <%= render partial: 'search/common/facet_sidebar_boolean_filter', locals: { facet: facet, resources: resources } %>
   <% end %>
 
+  <% resource_name = resource_type.model_name.human.downcase.pluralize %>
+  <%= render partial: 'search/common/facet_sidebar_boolean_filter',
+             locals: { facet_field: 'across_all_spaces',
+                       count: '-',
+                       enable_text: t('sidebar.filter.values.show_cross_space', resource: resource_name),
+                       disable_text: t('sidebar.filter.values.hide_cross_space', resource: resource_name) } %>
+
   <% if resource_type.name == 'Event' %>
     <%= render partial: 'search/common/facet_sidebar_boolean_filter',
         locals: { facet_field: 'include_expired',

app/views/search/common/_facet_sidebar_curation.html.erb

@@ -1,9 +1,7 @@
 <% show_last_scraped_filter = resource_type.method_defined?(:last_scraped) %>
 <% show_hidden_filter = resource_type.method_defined?(:user_requires_approval?) %>
-<% show_cross_space_filter = current_user&.is_admin? %>
-<% resource_name = resource_type.model_name.human.downcase.pluralize %>
 
-<% if show_last_scraped_filter || show_hidden_filter || show_cross_space_filter %>
+<% if show_last_scraped_filter || show_hidden_filter %>
   <ul class="unstyled nav-simple">
     <li>
       <h4 class="nav-heading mt-4">
@@ -47,13 +45,5 @@
           enable_text: t('sidebar.hidden.values.show_hidden'),
           disable_text: t('sidebar.hidden.values.hide_hidden') } %>
     <% end %>
-
-    <% if show_cross_space_filter %>
-      <%= render partial: 'search/common/facet_sidebar_boolean_filter',
-                 locals: { facet_field: 'across_all_spaces',
-                           count: '-',
-                           enable_text: t('sidebar.filter.values.show_cross_space', resource: resource_name),
-                           disable_text: t('sidebar.filter.values.hide_cross_space', resource: resource_name) } %>
-    <% end %>
   </ul>
 <% end %>

lib/facets.rb

@@ -140,7 +140,7 @@ def elixir(scope, value, _)
 
     def across_all_spaces(scope, value, user)
       sunspot_scoped(scope) do
-        all_spaces = (user&.is_admin? && value)
+        all_spaces = value
         with(:space_id, Space.current_space.id) unless all_spaces
       end
     end