Remove leftover accepts_nested_attributes_for stuff. Ensure all authors/contributors can be removed

Author: fbacall

app/assets/javascripts/people.js

@@ -41,10 +41,10 @@ const People = {
         return newForm;
     },
 
-    // This is just cosmetic. The actual removal is done by rails,
-    //   by virtue of the hidden checkbox being checked when the label is clicked.
     delete: function () {
-        $(this).parents('.person-form').fadeOut();
+        $(this).parents('.person-form').fadeOut('fast', function() {
+            $(this).remove();
+        });
     },
 
     init: function () {

app/models/concerns/has_people.rb

@@ -26,7 +26,7 @@ def set_people_for_role(value, role_name, role_key)
     current_people = send(role_name).to_a
     to_keep = []
 
-    value = value.values if value.respond_to?(:keys) && value.keys.first.match(/\A\d+\z/)
+    value = value.values if value.respond_to?(:keys) && value.keys.first&.match(/\A\d+\z/)
     Array.wrap(value).reject(&:blank?).map do |person_data|
       person_data = person_data.to_h if person_data.is_a?(ActionController::Parameters)
       if person_data.is_a?(String)

app/views/common/_people_form.html.erb

@@ -16,6 +16,9 @@
   <%= f.label field_name.to_sym, label, class: 'control-label' %>
   <%= f.field_lock(field_name.to_sym) if f.object.respond_to?(:locked_fields) %>
 
+  <%# This blank association is needed to trigger the delete when all associations are removed %>
+  <input type="hidden" name="<%= "#{model_name}[#{field_name}][0]" -%>" value=""/>
+
   <div data-role="people-form-list">
     <% f.object.send(field_name).each_with_index do |person, index| %>
       <%= render partial: 'common/person_form',

test/controllers/materials_controller_test.rb

@@ -291,7 +291,6 @@ class MaterialsControllerTest < ActionController::TestCase
     assert_equal test_material.other_types, JSON.parse(response.body)['other_types'], 'other_types not matched'
     #assert_equal test_material.events, JSON.parse(response.body)['events'], 'events not matched'
     assert_equal test_material.target_audience, JSON.parse(response.body)['target_audience'], 'target audience not matched'
-    # Authors is now an array of objects with id, name, orcid
     response_authors = JSON.parse(response.body)['authors']
     assert_equal test_material.authors.size, response_authors.size, 'authors count not matched'
     response_authors.each_with_index do |author_json, i|