Add optional belongs_to :profile on Person, auto-link by ORCID on save

Co-authored-by: fbacall <503373+fbacall@users.noreply.github.com>

Author: Copilot

app/models/person.rb

@@ -1,9 +1,13 @@
 class Person < ApplicationRecord
+  belongs_to :profile, optional: true
   has_many :person_links, dependent: :destroy
 
   # Validate that at least a full_name OR both given_name and family_name are present
   validate :name_presence
 
+  # Automatically link to profile based on ORCID on save
+  before_save :link_to_profile_by_orcid
+
   # Return the display name - full_name if present, otherwise construct from given_name and family_name
   def display_name
     full_name.presence || "#{given_name} #{family_name}".strip
@@ -16,4 +20,19 @@ def name_presence
       errors.add(:base, "Either full_name or both given_name and family_name must be present")
     end
   end
+
+  # Automatically link to a Profile if one exists with a matching ORCID
+  def link_to_profile_by_orcid
+    return if orcid.blank?
+    return if profile_id.present? # Already linked
+
+    # Normalize the ORCID for matching - Profile stores it as a full URL
+    normalized_orcid = orcid.strip
+    if normalized_orcid =~ OrcidValidator::ORCID_ID_REGEX
+      normalized_orcid = "#{OrcidValidator::ORCID_PREFIX}#{normalized_orcid}"
+    end
+
+    matching_profile = Profile.find_by(orcid: normalized_orcid)
+    self.profile = matching_profile if matching_profile.present?
+  end
 end

app/serializers/person_serializer.rb

@@ -1,5 +1,5 @@
 class PersonSerializer < ApplicationSerializer
-  attributes :id, :given_name, :family_name, :full_name, :orcid
+  attributes :id, :given_name, :family_name, :full_name, :orcid, :profile_id
 
   # Return display_name for API responses
   attribute :name do |person|

app/views/materials/show.json.jbuilder

@@ -21,8 +21,8 @@ json.nodes @material.associated_nodes.collect { |x| { name: x[:name], node_id: x
 json.collections @material.collections.collect { |x| { title: x[:title], id: x[:id] } }
 json.events @material.events.collect { |x| { title: x[:title], id: x[:id] } }
 
-json.authors @material.authors.collect { |a| { id: a.id, given_name: a.given_name, family_name: a.family_name, full_name: a.full_name, name: a.display_name, orcid: a.orcid } }
-json.contributors @material.contributors.collect { |c| { id: c.id, given_name: c.given_name, family_name: c.family_name, full_name: c.full_name, name: c.display_name, orcid: c.orcid } }
+json.authors @material.authors.collect { |a| { id: a.id, given_name: a.given_name, family_name: a.family_name, full_name: a.full_name, name: a.display_name, orcid: a.orcid, profile_id: a.profile_id } }
+json.contributors @material.contributors.collect { |c| { id: c.id, given_name: c.given_name, family_name: c.family_name, full_name: c.full_name, name: c.display_name, orcid: c.orcid, profile_id: c.profile_id } }
 
 json.external_resources do
   @material.external_resources.each do |external_resource|

db/migrate/20251119095244_create_people.rb

@@ -5,6 +5,7 @@ def change
       t.string :family_name
       t.string :full_name
       t.string :orcid
+      t.references :profile, null: true, foreign_key: true
 
       t.timestamps
     end

test/models/person_test.rb

@@ -39,4 +39,45 @@ class PersonTest < ActiveSupport::TestCase
     person = people(:horace)
     assert_respond_to person, :person_links
   end
+
+  test 'should allow optional profile association' do
+    person = Person.create(full_name: 'John Doe')
+    assert person.valid?
+    assert_nil person.profile
+  end
+
+  test 'should automatically link to profile by orcid on save' do
+    profile = profiles(:trainer_one_profile)
+    # The trainer_one_profile has orcid: https://orcid.org/000-0002-1825-0097
+    person = Person.create(full_name: 'Josiah Carberry', orcid: 'https://orcid.org/000-0002-1825-0097')
+    assert person.valid?
+    assert_equal profile, person.profile
+  end
+
+  test 'should automatically link to profile using short orcid format' do
+    profile = profiles(:trainer_one_profile)
+    # The trainer_one_profile has orcid: https://orcid.org/000-0002-1825-0097
+    person = Person.create(full_name: 'Josiah Carberry', orcid: '000-0002-1825-0097')
+    assert person.valid?
+    assert_equal profile, person.profile
+  end
+
+  test 'should not link to profile if no matching orcid' do
+    person = Person.create(full_name: 'John Doe', orcid: '0000-0001-9999-9999')
+    assert person.valid?
+    assert_nil person.profile
+  end
+
+  test 'should not override existing profile link' do
+    profile1 = profiles(:trainer_one_profile)
+    profile2 = profiles(:admin_trainer_profile)
+
+    # First, manually set a profile
+    person = Person.create(full_name: 'John Doe', profile: profile2)
+    assert_equal profile2, person.profile
+
+    # Even if we update the ORCID to match profile1, it should keep profile2
+    person.update(orcid: 'https://orcid.org/000-0002-1825-0097')
+    assert_equal profile2, person.profile
+  end
 end