Skip to content

Commit eb30e6c

Browse files
committed
fix recurring event date parsing in dans, add description to rdnl
1 parent f49cac1 commit eb30e6c

4 files changed

Lines changed: 13 additions & 6 deletions

File tree

lib/ingestors/taxila/dans_ingestor.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@ def process_dans(url)
3838
# dates
3939
dates = event_data.css("div[id='nieuws_image_date_row']").css('p').css('span')
4040
event.start = Time.zone.parse(dates[0].children.to_s)
41-
event.end = Time.zone.parse(dates[1].children.to_s) if dates.length == 2
41+
if dates.length == 2
42+
event.end = Time.zone.parse(dates[1].children.to_s)
43+
else
44+
event.end = nil # to prevent recurring events from getting weird values
45+
end
4246
event.set_default_times
4347

4448
data = event_data.css("div[id='nieuws_content_row']").css('div')[0].css('div')[0]

lib/ingestors/taxila/rdnl_ingestor.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ def process_rdnl(url)
5050
event.end = event.end.change(year: Time.now.year + 1)
5151
end
5252

53+
event.description = event_data.css('.card__excerpt > p')[0].text.strip
54+
puts event.description
55+
5356
event.venue = event_data.css('dl.meta-list > div > dd')[1].text.strip
5457
event.source = 'RDNL'
5558
event.timezone = 'Amsterdam'

test/unit/ingestors/taxila/rdnl_ingestor_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class RDNLIngestorTest < ActiveSupport::TestCase
5252
assert_equal 'RDNL', event.source
5353
assert_equal 'Amsterdam', event.timezone
5454
assert_equal 'DANS-KNAW', event.venue
55-
assert_equal Time.zone.parse('Thu, 5 Feb 2026 09:00:00.000000000 UTC +00:00'), event.start
55+
assert_equal Time.zone.parse('Tue, 10 Feb 2026 09:00:00.000000000 UTC +00:00'), event.start
5656
assert_equal Time.zone.parse('Mon, 26 Mar 2026 17:00:00.000000000 UTC +00:00'), event.end
5757
end
5858
end

test/vcr_cassettes/ingestors/rdnl.yml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)