comments

Author: mikesndrs

lib/ingestors/taxila/citizen_science_ingestor.rb

@@ -37,6 +37,8 @@ def process_citizen_science_events(_url)
                                        &.css('.row')&.first
                                        &.css('.card')
 
+        return if overview_page.nil?
+
         overview_page.each_with_index do |el, _idx|
           event = OpenStruct.new
           event.url = el.css('a.btn').first['href']
@@ -80,18 +82,18 @@ def process_citizen_science_materials(_url)
           end
         end
       end
-    end
-  end
-end
 
-def citizen_science_month_mapping(str)
-  mapping = [
-    %w[Mrt Mar],
-    %w[Mei May],
-    %w[Okt Oct]
-  ]
-  mapping.each do |dutch, english|
-    str = str.gsub(dutch, english)
+      def citizen_science_month_mapping(str)
+        mapping = [
+          %w[Mrt Mar],
+          %w[Mei May],
+          %w[Okt Oct]
+        ]
+        mapping.each do |dutch, english|
+          str = str.gsub(dutch, english)
+        end
+        str
+      end
+    end
   end
-  str
 end

test/unit/ingestors/taxila/citizen_science_ingestor_test.rb

@@ -17,7 +17,7 @@ class CitizenScienceIngestorTest < ActiveSupport::TestCase
 
     ingestor = Ingestors::Taxila::CitizenScienceIngestor.new
 
-    # check event doesn't
+    # check event doesn't exist yet
     new_title = 'High-Level Policy Event on the Sustainability of Citizen Science'
     new_url = 'https://events.teams.microsoft.com/event/47581424-c548-4f07-928a-9fed358df416@659b3608-37a1-406b-9e1a-02c011decd3c'
     refute Event.where(title: new_title, url: new_url).any?
@@ -61,7 +61,7 @@ class CitizenScienceIngestorTest < ActiveSupport::TestCase
 
     ingestor = Ingestors::Taxila::CitizenScienceIngestor.new
 
-    # check event doesn't
+    # check material doesn't exist yet
     new_title = 'Naar een vaste plek voor burgerwetenschap in het netwerk van openbare bibliotheken'
     new_url = 'https://www.citizenscience.nl/resource/475'
     refute Material.where(title: new_title, url: new_url).any?