Skip to content

Commit f9f22a2

Browse files
fbacallCopilot
andcommitted
Apply suggestions from code review
Operator precedence clarity & fixes etc. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent f753c34 commit f9f22a2

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/assets/stylesheets/application.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1076,7 +1076,7 @@ td.day .calendar-text {
10761076

10771077
.theme-selector {
10781078
display: flex;
1079-
gap: 10px
1079+
gap: 10px;
10801080
}
10811081

10821082
.theme-select-option {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
class ContentProviderPolicy < ScrapedResourcePolicy
22
def create_source?
3-
TeSS::Config.feature['user_source_creation'] && manage? ||
3+
(TeSS::Config.feature['user_source_creation'] && manage?) ||
44
user_has_role?(:admin, :curator)
55
end
66
end

app/policies/source_policy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def request_approval?
2727
private
2828

2929
def administration? # Can edit sources for any content provider
30-
curators_and_admin || user_has_role?(:admin)
30+
curators_and_admin
3131
end
3232

3333
def user_management?

app/views/layouts/_user_menu.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
</li>
4141
<% end %>
4242

43-
<% if !TeSS::Config.feature['disabled'].include?('topics') && is_admin || is_curator %>
43+
<% if !TeSS::Config.feature['disabled'].include?('topics') && (is_admin || is_curator) %>
4444
<li class="dropdown-item">
4545
<%= link_to curate_topic_suggestions_path,
4646
title: t('menu.user.assign_scientific_topics',

0 commit comments

Comments
 (0)