Spaces#1094
Merged
Merged
Conversation
cwant
reviewed
Apr 10, 2025
| existing_items_method: :administrators %> | ||
|
|
||
| <div class="form-group"> | ||
| <%= f.submit ( f.object.new_record? ? "Register" : "Update") + " space", class: 'btn btn-primary' %> |
cwant
reviewed
Apr 10, 2025
cwant
left a comment
cwant
left a comment
Contributor
There was a problem hiding this comment.
Just a brief scan (view mostly) to locate spots where I saw some strings that don't go through i18n.
| Create space | ||
| <% end %> | ||
| <% end %> | ||
| <%= info_button("What are spaces?", hide_text: true) do %> |
Contributor
There was a problem hiding this comment.
This (and following line) should go through i18n
| <div class="text-right my-3"> | ||
| <% if policy(:space).create? %> | ||
| <%= link_to new_space_path, class: 'btn btn-primary' do %> | ||
| Create space |
| @@ -0,0 +1,3 @@ | |||
| <%= info_box('What are space?') do %> | |||
| @@ -0,0 +1,12 @@ | |||
| <%- model_class = Space -%> | |||
| <div class="page-header"> | |||
| <%= page_title(t('.title', default: [:'helpers.titles.new', 'New %{model}'], model: model_class.model_name.human.titleize.downcase)) %> | |||
fbacall
marked this pull request as ready for review
May 12, 2025 08:38
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the Multi-Space feature to TeSS, enabling independently managed spaces with custom theming and content segregation. The key changes include:
- Adding a link to a themes directory in the asset manifest to support space-specific styling.
- Updating the README to include documentation on configuring and using multi-space TeSS.
Reviewed Changes
Copilot reviewed 83 out of 101 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/assets/config/manifest.js | Changed asset linking to use a themes directory for CSS files. |
| README.md | Added a section with documentation for the multi-space feature. |
Files not reviewed (18)
- app/assets/images/themes/blue: Language not supported
- app/assets/images/themes/default: Language not supported
- app/assets/images/themes/green: Language not supported
- app/assets/images/themes/space: Language not supported
- app/assets/javascripts/templates/autocompleter/user_id.hbs: Language not supported
- app/assets/stylesheets/application.scss: Language not supported
- app/assets/stylesheets/bootstrap-tweaks.scss: Language not supported
- app/assets/stylesheets/home.scss: Language not supported
- app/assets/stylesheets/icons.scss: Language not supported
- app/assets/stylesheets/learning-paths.scss: Language not supported
- app/assets/stylesheets/masonry.scss: Language not supported
- app/assets/stylesheets/mixins/mixins.scss: Language not supported
- app/assets/stylesheets/mixins/variables.scss: Language not supported
- app/assets/stylesheets/themes/blue.scss: Language not supported
- app/assets/stylesheets/themes/classic.scss: Language not supported
- app/assets/stylesheets/themes/default.scss: Language not supported
- app/assets/stylesheets/themes/green.scss: Language not supported
- app/assets/stylesheets/themes/mixins/_modern_base.scss: Language not supported
Comments suppressed due to low confidence (1)
app/assets/config/manifest.js:2
- Removing the link to application.css may result in missing default styles if those styles are not migrated to the themes directory. Please ensure that all necessary styles from application.css are included in or referenced by the themes directory.
//= link_directory ../stylesheets/themes .css
…current space when browsing
…ain circumstances
Allow icons to be re-coloured per-theme. Allow theme to be selected on space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Hostheader of the HTTP request. If no space exists for that host, the Default Space is set.Motivation and context
Part of the mTeSS-X OSCARS project.
Screenshots
Checklist
to license it to the TeSS codebase under the
BSD license.