Skip to content

flash-container duplicate in workflows.html.erb (small fix) - #1131

Merged
fbacall merged 3 commits into
ElixirTeSS:masterfrom
kennethrioja:patch-2
Aug 27, 2025
Merged

flash-container duplicate in workflows.html.erb (small fix)#1131
fbacall merged 3 commits into
ElixirTeSS:masterfrom
kennethrioja:patch-2

Conversation

@kennethrioja

Copy link
Copy Markdown
Contributor

Summary of changes

  • Deleting div flash-container in workflows.html.erb

Motivation and context

Stumbled upon this duplication while logging in from the Workflows page

Screenshots

image

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

@kennethrioja kennethrioja changed the title flash-container duplicate in workflows.html.erb flash-container duplicate in workflows.html.erb (small fix) Jul 28, 2025

@fbacall fbacall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the following code:
https://github.com/ElixirTeSS/TeSS/blob/master/app/controllers/workflows_controller.rb#L27

https://github.com/ElixirTeSS/TeSS/blob/master/app/views/layouts/_header.html.erb#L96-L100

that was supposed to prevent this duplication occurring, but it looks like it was not applied to all cases where the workflows layout is used.

I think you should just remove the @skip_flash_messages_in_header variable and its uses

@kennethrioja

Copy link
Copy Markdown
Contributor Author

I just removed @skip_flash_messages_in_header and its uses but kept the flash-container deleted as it is almost a duplicate from the one in _header.html.erb

-> I checked where class="workflows-container" was used, and I don't find any specific use to this specific flash-container

@fbacall
fbacall merged commit 2937ba2 into ElixirTeSS:master Aug 27, 2025
7 checks passed
@kennethrioja
kennethrioja deleted the patch-2 branch January 7, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants