Skip to content

[csv ingestor] Fix material.licence when nil#1163

Merged
fbacall merged 2 commits into
ElixirTeSS:masterfrom
kennethrioja:fix-gsheet
Dec 16, 2025
Merged

[csv ingestor] Fix material.licence when nil#1163
fbacall merged 2 commits into
ElixirTeSS:masterfrom
kennethrioja:fix-gsheet

Conversation

@kennethrioja

Copy link
Copy Markdown
Contributor

Summary of changes

  • Added a method to check for nil licence

Motivation and context

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree to license it to the TeSS codebase under the BSD license.

Comment on lines +235 to +240
def ingestor.get_column(*)
raise CSV::MalformedCSVError.new('test failure', 22)
end

ingestor.read(source.url)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better/safer to use minitest's stubbing:

ingestor.stub(:get_column, -> { raise CSV::MalformedCSVError.new('test failure', 22) }) do
  ingestor.read(source.url)
end

@fbacall
fbacall merged commit b476768 into ElixirTeSS:master Dec 16, 2025
7 checks passed
@kennethrioja
kennethrioja deleted the fix-gsheet branch December 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants