Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dropdown control to adjust the number of search results displayed per page, addressing issue #1195. Users can now select from predefined page sizes (10, 20, 50, 100) instead of being limited to the default of 10 results per page.
- Adds page size selection dropdown to the search results interface
- Introduces constants for default page size and available options
- Implements JavaScript function to handle page size changes via URL parameter updates
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| config/locales/en.yml | Adds translation key for the "Results per page" label |
| app/views/search/common/_search_panel.html.erb | Adds dropdown UI control for page size selection with inline form styling |
| app/helpers/application_helper.rb | Implements helper method to generate page size options with current selection |
| app/controllers/concerns/searchable_index.rb | Defines page size constants and updates default page size reference |
| app/assets/stylesheets/application.scss | Adds styling for the page size dropdown with custom border and transparent background |
| app/assets/javascripts/application.js | Implements function to update URL with selected page size and trigger page reload |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
#1195
Screenshots
Checklist
to license it to the TeSS codebase under the
BSD license.