Move source test results location#1341
Open
fbacall wants to merge 1 commit into
Open
Conversation
So they can be symlinked if necessary
Contributor
There was a problem hiding this comment.
Pull request overview
Moves persisted “source test results” YAML files into a dedicated subdirectory under tmp/ to make the storage location easier to share (e.g., via symlinks) across multiple app instances in a shared deployment.
Changes:
- Change
HasTestJob#test_results_pathto write/read results undertmp/source_test_results/instead of directly undertmp/. - Add on-demand creation of the
tmp/source_test_resultsdirectory when computing the results path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def test_results_path | ||
| path_id = Rails.env.test? ? "fakeid_#{model_name.singular}_#{id}" : test_job_id | ||
| File.join(Rails.root, 'tmp', "test_results_#{path_id}.yml") | ||
| Rails.root.join('tmp', 'source_test_results').tap { |d| d.mkdir unless d.exist? }.join("test_results_#{path_id}.yml") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
tmpinstead of in there directly.Motivation and context
In a deployment where 2 app instances are sharing DB/storage, one instance could not access test results run on the other. After this change it is possible via symlinks.
Checklist