Merge pull request #3 from EllanServer/codex/optimize-display-culling

Author: Arbousier1

.github/workflows/benchmark.yml

@@ -0,0 +1,91 @@
+name: A-B Performance Benchmark
+
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - '.github/workflows/benchmark.yml'
+      - 'benchmark/**'
+      - 'build.gradle.kts'
+      - 'common/src/main/java/com/loohp/interactionvisualizer/entities/DroppedItemDisplay.java'
+      - 'common/src/main/java/com/loohp/interactionvisualizer/entities/DroppedItemSpatialIndex.java'
+      - 'common/src/main/java/com/loohp/interactionvisualizer/entities/VisibilityTokenBucket.java'
+
+permissions:
+  contents: read
+
+jobs:
+  benchmark:
+    name: Paper 26.1.2 A-B benchmark
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Set up Java 25
+        uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: "25"
+
+      - name: Set up Gradle
+        uses: gradle/actions/setup-gradle@v4
+
+      - name: Build disposable benchmark plugin
+        run: ./gradlew benchmarkJar --no-daemon --no-build-cache --rerun-tasks
+
+      - name: Download stable Paper 26.1.2
+        env:
+          PAPER_USER_AGENT: InteractionVisualizer-Benchmark/1.0 (https://github.com/EllanServer/InteractionVisualizer)
+        run: |
+          mkdir -p benchmark-server/plugins
+          BUILDS=$(curl --fail --silent --show-error \
+            -H "User-Agent: $PAPER_USER_AGENT" \
+            https://fill.papermc.io/v3/projects/paper/versions/26.1.2/builds)
+          PAPER_URL=$(echo "$BUILDS" | jq -r 'first(.[] | select(.channel == "STABLE") | .downloads."server:default".url) // empty')
+          test -n "$PAPER_URL"
+          curl --fail --location --show-error \
+            -H "User-Agent: $PAPER_USER_AGENT" \
+            --output benchmark-server/server.jar "$PAPER_URL"
+          cp build/libs/InteractionVisualizer-*-benchmark.jar benchmark-server/plugins/
+
+      - name: Configure isolated benchmark server
+        working-directory: benchmark-server
+        run: |
+          echo 'eula=true' > eula.txt
+          cat > server.properties <<'EOF'
+          online-mode=false
+          level-name=benchmark-world
+          level-type=minecraft:flat
+          generate-structures=false
+          spawn-protection=0
+          view-distance=3
+          simulation-distance=3
+          max-players=1
+          max-tick-time=-1
+          sync-chunk-writes=false
+          EOF
+
+      - name: Run alternating A-B measurements
+        working-directory: benchmark-server
+        run: |
+          java -Xms2G -Xmx2G -XX:+UseG1GC -jar server.jar --nogui | tee benchmark-server.log
+          test -f plugins/InteractionVisualizerBenchmark/benchmark-results.jsonl
+          test -f plugins/InteractionVisualizerBenchmark/benchmark-complete.txt
+          EXPECTED_RESULTS=$(cat plugins/InteractionVisualizerBenchmark/benchmark-complete.txt)
+          ACTUAL_RESULTS=$(wc -l < plugins/InteractionVisualizerBenchmark/benchmark-results.jsonl)
+          test "$ACTUAL_RESULTS" -eq "$EXPECTED_RESULTS"
+
+      - name: Publish benchmark results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: interactionvisualizer-ab-${{ github.sha }}
+          path: |
+            benchmark-server/plugins/InteractionVisualizerBenchmark/benchmark-results.jsonl
+            benchmark-server/plugins/InteractionVisualizerBenchmark/benchmark-complete.txt
+            benchmark-server/benchmark-server.log
+          if-no-files-found: warn
+          retention-days: 30

.github/workflows/build.yml

@@ -29,6 +29,59 @@ jobs:
       - name: Set up Gradle
         uses: gradle/actions/setup-gradle@v4
 
+      - name: Validate performance tooling
+        shell: pwsh
+        run: |
+          $ErrorActionPreference = 'Stop'
+          $scripts = @(
+            'tools/perf/phase2-pktmon.ps1',
+            'tools/perf/analyze-presentmon.ps1',
+            'tools/perf/analyze-minecraft-debug-profile.ps1',
+            'tools/perf/analyze-jfr-socket-writes.ps1',
+            'tools/perf/analyze-phase2-abba.ps1',
+            'tools/perf/analyze-phase2-pcap.ps1'
+          )
+          foreach ($script in $scripts) {
+            [void][scriptblock]::Create((Get-Content -Raw -LiteralPath $script))
+          }
+          $pktmonSelfTestJson = & ./tools/perf/phase2-pktmon.ps1 selftest | Out-String
+          $pktmonSelfTest = $pktmonSelfTestJson | ConvertFrom-Json
+          if (-not $pktmonSelfTest.passed) {
+            throw 'PktMon wrapper self-test did not report passed=true.'
+          }
+          $selfTestJson = & ./tools/perf/analyze-presentmon.ps1 -SelfTest | Out-String
+          $selfTest = $selfTestJson | ConvertFrom-Json
+          if (-not $selfTest.passed) {
+            throw 'PresentMon analyzer self-test did not report passed=true.'
+          }
+          $debugProfileSelfTestJson = & ./tools/perf/analyze-minecraft-debug-profile.ps1 -SelfTest | Out-String
+          $debugProfileSelfTest = $debugProfileSelfTestJson | ConvertFrom-Json
+          if (-not $debugProfileSelfTest.passed) {
+            throw 'Minecraft debug-profile analyzer self-test did not report passed=true.'
+          }
+          $jfrSelfTestJson = & ./tools/perf/analyze-jfr-socket-writes.ps1 -SelfTest | Out-String
+          $jfrSelfTest = $jfrSelfTestJson | ConvertFrom-Json
+          if (-not $jfrSelfTest.passed) {
+            throw 'JFR socket-write analyzer self-test did not report passed=true.'
+          }
+          $abbaSelfTestJson = & ./tools/perf/analyze-phase2-abba.ps1 -SelfTest | Out-String
+          $abbaSelfTest = $abbaSelfTestJson | ConvertFrom-Json
+          if (-not $abbaSelfTest.passed) {
+            throw 'Phase 2 ABBA analyzer self-test did not report passed=true.'
+          }
+          $pcapSelfTestJson = & ./tools/perf/analyze-phase2-pcap.ps1 -SelfTest | Out-String
+          $pcapSelfTest = $pcapSelfTestJson | ConvertFrom-Json
+          if (-not $pcapSelfTest.passed) {
+            throw 'Phase 2 pcap analyzer self-test did not report passed=true.'
+          }
+
+      - name: Validate runtime harness syntax
+        shell: bash
+        run: |
+          bash -n tools/perf/prepare-phase2-protocol-client.sh
+          bash -n tools/perf/run-phase2-runtime-once.sh
+          node --check tools/perf/phase2-protocol-client.js
+
       - name: Run checks and build production jar
         run: ./gradlew clean check shadowJar --no-daemon --no-build-cache --rerun-tasks