Fix runtime profile evidence source

Author: Arbousier1

benchmark-runtime/src/main/java/com/loohp/interactionvisualizer/benchmark/runtime/RuntimeComparisonPlugin.java

@@ -165,8 +165,8 @@ private boolean setup(CommandSender sender, String[] args) {
     }
 
     private boolean start(CommandSender sender, String[] args) {
-        if (args.length != 3) {
-            sender.sendMessage("Usage: /ivcompare start <label> <A|B>");
+        if (args.length != 4) {
+            sender.sendMessage("Usage: /ivcompare start <label> <A|B> <legacy-parity|optimized-candidate>");
             return true;
         }
         if (collecting) {
@@ -187,7 +187,8 @@ private boolean start(CommandSender sender, String[] args) {
         }
         label = sanitize(args[1]);
         variant = requestedVariant;
-        requestedFlags = readRequestedFlags(target);
+        String runtimeProfile = args[3].toLowerCase(Locale.ROOT);
+        requestedFlags = requestedFlagsForProfile(runtimeProfile);
         effectiveFlags = inspectEffectiveFlags(target.getClass());
         assertOptimizationProfile(variant, requestedFlags, effectiveFlags);
         tickSamples = 0;
@@ -196,7 +197,10 @@ private boolean start(CommandSender sender, String[] args) {
         startedNanos = System.nanoTime();
         skipNextTickSample = true;
         collecting = true;
-        String record = "IV_COMPARE_START label=" + label + " variant=" + variant;
+        String record = "IV_COMPARE_START label=" + label + " variant=" + variant
+                + " runtimeProfile=" + runtimeProfile
+                + " requestedPacketOnlyStatic=" + requestedFlags.packetOnlyStatic()
+                + " requestedEventDrivenBlockUpdates=" + requestedFlags.eventDrivenBlockUpdates();
         getLogger().info(record);
         sender.sendMessage(record);
         return true;
@@ -459,15 +463,13 @@ private static String sanitize(String value) {
         return sanitized.substring(0, Math.min(64, sanitized.length()));
     }
 
-    static RequestedFlags readRequestedFlags(Plugin target) {
-        if (!(target instanceof JavaPlugin javaPlugin)) {
-            throw new IllegalStateException("InteractionVisualizer target is not a JavaPlugin");
-        }
-        return new RequestedFlags(
-                javaPlugin.getConfig().getBoolean(
-                        "Settings.Performance.VirtualItems.PacketOnlyStatic"),
-                javaPlugin.getConfig().getBoolean(
-                        "Settings.Performance.BlockUpdates.EventDriven"));
+    static RequestedFlags requestedFlagsForProfile(String runtimeProfile) {
+        return switch (runtimeProfile) {
+            case "legacy-parity" -> RequestedFlags.disabled();
+            case "optimized-candidate" -> new RequestedFlags(true, true);
+            default -> throw new IllegalArgumentException(
+                    "runtime profile must be legacy-parity or optimized-candidate");
+        };
     }
 
     static EffectiveFlags inspectEffectiveFlags(Class<?> targetClass) {

common/src/test/java/com/loohp/interactionvisualizer/benchmark/runtime/RuntimeComparisonPluginTest.java

@@ -22,6 +22,18 @@
 
 class RuntimeComparisonPluginTest {
 
+    @Test
+    void requestedFlagsComeFromTheControlledRuntimeProfile() {
+        assertEquals(
+                new RuntimeComparisonPlugin.RequestedFlags(false, false),
+                RuntimeComparisonPlugin.requestedFlagsForProfile("legacy-parity"));
+        assertEquals(
+                new RuntimeComparisonPlugin.RequestedFlags(true, true),
+                RuntimeComparisonPlugin.requestedFlagsForProfile("optimized-candidate"));
+        assertThrows(IllegalArgumentException.class,
+                () -> RuntimeComparisonPlugin.requestedFlagsForProfile("unknown"));
+    }
+
     @Test
     void legacyTargetIsRecordedAsUnsupported() {
         RuntimeComparisonPlugin.EffectiveFlags flags =

tools/perf/run-upstream-runtime-once.sh

@@ -489,8 +489,8 @@ fi
 assert_client_alive
 send_console "ivcompare status"
 wait_for_log "IV_COMPARE_STATUS collecting=false scenario=$scenario expected=$scene_size actual=$scene_size player=IVBench targetEnabled=true activeFurnaces=$expected_active_furnaces" 30
-send_console "ivcompare start $run_id $variant"
-wait_for_log "IV_COMPARE_START label=$run_id variant=$variant" 30
+send_console "ivcompare start $run_id $variant $runtime_profile"
+wait_for_log "IV_COMPARE_START label=$run_id variant=$variant runtimeProfile=$runtime_profile" 30
 sleep "$measure_seconds"
 send_console "ivcompare stop"
 wait_for_log "IV_COMPARE {\"schemaVersion\":1,\"label\":\"$run_id\"" 60