Skip to content

Commit a8fd4c9

Browse files
committed
Pin runtime benchmarks to Paper 26.1.2
1 parent 2120e45 commit a8fd4c9

2 files changed

Lines changed: 7 additions & 15 deletions

File tree

.github/workflows/phase2-runtime-ab.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,6 @@ on:
55
types: [opened, synchronize, reopened, labeled]
66
workflow_dispatch:
77
inputs:
8-
paper_version:
9-
description: "Paper runtime under test (26.2 currently uses the BETA channel)"
10-
required: true
11-
default: "26.1.2"
12-
type: choice
13-
options: ["26.1.2", "26.2"]
148
ab_factor:
159
description: "Independent A/B factor with an isolated matching workload"
1610
required: true
@@ -70,7 +64,7 @@ jobs:
7064
timeout-minutes: 130
7165
env:
7266
CAMPAIGN_AB_FACTOR: ${{ github.event_name == 'workflow_dispatch' && inputs.ab_factor || 'scenario-config' }}
73-
CAMPAIGN_PAPER_VERSION: ${{ github.event_name == 'workflow_dispatch' && inputs.paper_version || '26.1.2' }}
67+
CAMPAIGN_PAPER_VERSION: "26.1.2"
7468
CAMPAIGN_SCENARIO: ${{ github.event_name == 'workflow_dispatch' && inputs.scenario || 'static-steady' }}
7569
CAMPAIGN_RUNS: ${{ github.event_name == 'workflow_dispatch' && inputs.runs || github.event.action == 'labeled' && '12' || '4' }}
7670
CAMPAIGN_ITEMS: ${{ github.event_name == 'workflow_dispatch' && inputs.items || github.event.action == 'labeled' && '4096' || '1024' }}

tools/perf/run-phase2-runtime-once.sh

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ set -euo pipefail
77

88
plugin_enabled_log_marker() {
99
case "${1:-}" in
10-
26.1.2|26.2)
10+
26.1.2)
1111
printf '[InteractionVisualizer] Enabled for Paper %s!' "$1"
1212
;;
1313
*)
@@ -19,13 +19,11 @@ plugin_enabled_log_marker() {
1919
if [[ "${1:-}" == --self-test ]]; then
2020
[[ "$(plugin_enabled_log_marker 26.1.2)" == \
2121
'[InteractionVisualizer] Enabled for Paper 26.1.2!' ]]
22-
[[ "$(plugin_enabled_log_marker 26.2)" == \
23-
'[InteractionVisualizer] Enabled for Paper 26.2!' ]]
24-
if plugin_enabled_log_marker 26.3 >/dev/null 2>&1; then
25-
echo 'runtime harness accepted an unsupported Paper version' >&2
22+
if plugin_enabled_log_marker 26.2 >/dev/null 2>&1; then
23+
echo 'runtime harness accepted a non-canonical Paper version' >&2
2624
exit 1
2725
fi
28-
printf '{"passed":true,"paperEnableMarkers":["26.1.2","26.2"]}\n'
26+
printf '{"passed":true,"canonicalPaperVersion":"26.1.2","paperEnableMarkers":["26.1.2"]}\n'
2927
exit 0
3028
fi
3129

@@ -79,8 +77,8 @@ case "$variant" in
7977
*) echo "PHASE2_VARIANT must be A or B" >&2; exit 64 ;;
8078
esac
8179
case "$paper_version" in
82-
26.1.2|26.2) ;;
83-
*) echo "PHASE2_PAPER_VERSION must be 26.1.2 or 26.2" >&2; exit 64 ;;
80+
26.1.2) ;;
81+
*) echo "PHASE2_PAPER_VERSION must be the canonical benchmark version 26.1.2" >&2; exit 64 ;;
8482
esac
8583
case "$paper_channel" in
8684
STABLE|BETA|UNKNOWN) ;;

0 commit comments

Comments
 (0)