fix: also migrate TableDiceAnimationCoordinator off the removed World.spawn Consumer overload

1.1.1 only fixed the four call sites inside DisplayEntities. The
opening-roll animation in TableDiceAnimationCoordinator has two more
(spawnDie + spawnResultLabel) that still bind to the deprecated
org.bukkit.util.Consumer overload, so /mahjong botmatch and any other
trigger of the dice animation still threw NoSuchMethodError on Paper
1.21+.

- Switch both helpers to World.spawn(Location, Class) followed by
  property assignments, matching the DisplayEntities pattern.
- Preserve the return value from spawnResultLabel so the caller can
  continue to track the spawned TextDisplay.

To stop this regressing again, add an architecture boundary test that
scans every production Java/Kotlin source and rejects any three-argument
World.spawn(Location, Class, lambda) call site. The portable two-argument
spawn is fine; new lambda-based spawns will fail CI.

Bump to 1.1.2 and document the missed-callsite hotfix in CHANGELOG.

Author: Arbousier1

CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 1.1.2 - 2026-06-16
+
+Follow-up hotfix to 1.1.1. The Paper 1.21+ `NoSuchMethodError` regression had two more call sites that were not migrated in 1.1.1.
+
+中文更新日志:
+
+- 漏修补全: 1.1.1 只迁移了 `DisplayEntities` 里的 4 处 `World.spawn(..., Consumer)`，但 `TableDiceAnimationCoordinator` 里另有 2 处（开局骰子动画的骰子实体和结果文本），它们仍然命中已被移除的 `org.bukkit.util.Consumer` 重载。在 Paper 1.21+ 上一执行 `/mahjong botmatch` 等会触发开局动画的命令就抛 `NoSuchMethodError`。本版本把这两处改为同样的 spawn-then-configure 模式。
+- 防回归门禁: 新增 `ArchitectureBoundaryTest.World spawn callers do not use the removed Consumer overload`，扫描所有生产 Java/Kotlin 源码，禁止任何 `World.spawn(Location, Class, lambda)` 三参数调用形式。下次有人无意把 lambda 写回 spawn 调用就会在 CI 失败，避免再次引入相同 bug。
+
+English Release Notes:
+
+- Missed callsites: 1.1.1 only migrated the four `World.spawn(..., Consumer)` calls in `DisplayEntities`, but `TableDiceAnimationCoordinator` had two more (the opening-roll dice entities and the result text label) that still bound to the removed `org.bukkit.util.Consumer` overload. Any command that triggers the opening dice animation, e.g. `/mahjong botmatch`, threw `NoSuchMethodError` on Paper 1.21+. Both sites now use the same spawn-then-configure pattern.
+- Regression gate: added `ArchitectureBoundaryTest.World spawn callers do not use the removed Consumer overload`. It scans every production Java/Kotlin source file and rejects any three-argument `World.spawn(Location, Class, lambda)` call site, so the same class of bug fails CI before it can ship again.
+
 ## 1.1.1 - 2026-06-16
 
 Hotfix release for Paper 1.21+ servers. 1.1.0 was unusable on Paper 1.21.x because every entity render path tripped a `NoSuchMethodError`.

build.gradle.kts

@@ -14,7 +14,7 @@ plugins {
 }
 
 group = "top.ellan"
-version = "1.1.1"
+version = "1.1.2"
 
 val minimumPaperDevBundleVersion = "1.20.1-R0.1-SNAPSHOT"
 val latestPaperDevBundleVersion = "26.2-rc-2.build.9-alpha"

src/main/java/top/ellan/mahjong/table/presentation/TableDiceAnimationCoordinator.java

@@ -166,22 +166,22 @@ private TextDisplay updateResultLabel(Component text) {
     }
 
     private TextDisplay spawnResultLabel(Component text) {
-        return this.world.spawn(
+        // See spawnDie: avoid the org.bukkit.util.Consumer overload that 1.21+ removed.
+        TextDisplay spawned = this.world.spawn(
             this.center.clone().add(0.0D, RESULT_LABEL_Y, 0.0D),
-            TextDisplay.class,
-            spawned -> {
-                spawned.setPersistent(false);
-                spawned.text(text);
-                spawned.setSeeThrough(false);
-                spawned.setShadowed(true);
-                spawned.setDefaultBackground(false);
-                spawned.setBillboard(Display.Billboard.CENTER);
-                spawned.setLineWidth(180);
-                spawned.setViewRange(32.0F);
-                spawned.setBrightness(new Display.Brightness(15, 15));
-                spawned.setBackgroundColor(Color.fromARGB(104, 20, 20, 24));
-            }
+            TextDisplay.class
         );
+        spawned.setPersistent(false);
+        spawned.text(text);
+        spawned.setSeeThrough(false);
+        spawned.setShadowed(true);
+        spawned.setDefaultBackground(false);
+        spawned.setBillboard(Display.Billboard.CENTER);
+        spawned.setLineWidth(180);
+        spawned.setViewRange(32.0F);
+        spawned.setBrightness(new Display.Brightness(15, 15));
+        spawned.setBackgroundColor(Color.fromARGB(104, 20, 20, 24));
+        return spawned;
     }
 
     private void animateRollingDie(ItemDisplay display, double baseX, long tick, double driftZ, double tiltBias, float yawBias) {
@@ -215,27 +215,31 @@ private void positionSettledDie(ItemDisplay display, double xOffset, float yaw)
     }
 
     private ItemDisplay spawnDie(Location location, int point) {
-        return this.world.spawn(location, ItemDisplay.class, spawned -> {
-            spawned.setPersistent(false);
-            spawned.setItemDisplayTransform(ItemDisplay.ItemDisplayTransform.HEAD);
-            spawned.setInterpolationDuration(1);
-            spawned.setInterpolationDelay(0);
-            PaperCompatibility.setTeleportDuration(spawned, 1);
-            spawned.setViewRange(20.0F);
-            spawned.setShadowRadius(0.0F);
-            spawned.setShadowStrength(0.0F);
-            spawned.setDisplayWidth(0.45F * DIE_SCALE);
-            spawned.setDisplayHeight(0.45F * DIE_SCALE);
-            spawned.setBillboard(Display.Billboard.FIXED);
-            spawned.setBrightness(new Display.Brightness(15, 15));
-            spawned.setItemStack(diceItem(point));
-            spawned.setTransformation(new Transformation(
-                this.zeroTranslation,
-                this.identityRotation,
-                this.dieScaleVector,
-                this.identityRotation
-            ));
-        });
+        // World.spawn(Location, Class, Consumer) binds to the deprecated
+        // org.bukkit.util.Consumer overload under the 1.20.1 dev bundle, which
+        // Paper 1.21+ has removed. Use the long-stable two-argument spawn and
+        // configure the entity afterwards. See DisplayEntities for the same fix.
+        ItemDisplay spawned = this.world.spawn(location, ItemDisplay.class);
+        spawned.setPersistent(false);
+        spawned.setItemDisplayTransform(ItemDisplay.ItemDisplayTransform.HEAD);
+        spawned.setInterpolationDuration(1);
+        spawned.setInterpolationDelay(0);
+        PaperCompatibility.setTeleportDuration(spawned, 1);
+        spawned.setViewRange(20.0F);
+        spawned.setShadowRadius(0.0F);
+        spawned.setShadowStrength(0.0F);
+        spawned.setDisplayWidth(0.45F * DIE_SCALE);
+        spawned.setDisplayHeight(0.45F * DIE_SCALE);
+        spawned.setBillboard(Display.Billboard.FIXED);
+        spawned.setBrightness(new Display.Brightness(15, 15));
+        spawned.setItemStack(diceItem(point));
+        spawned.setTransformation(new Transformation(
+            this.zeroTranslation,
+            this.identityRotation,
+            this.dieScaleVector,
+            this.identityRotation
+        ));
+        return spawned;
     }
 
     private Location baseLocation(double xOffset) {

src/test/kotlin/top/ellan/mahjong/architecture/ArchitectureBoundaryTest.kt

@@ -173,6 +173,35 @@ class ArchitectureBoundaryTest {
         )
     }
 
+    @Test
+    fun `World spawn callers do not use the removed Consumer overload`() {
+        // Paper 1.21+ removed the deprecated org.bukkit.util.Consumer overload of
+        // World.spawn(Location, Class, Consumer). Lambdas compiled against the 1.20
+        // dev bundle were silently bound to that removed overload, breaking every
+        // render tick on 1.21+ servers (see commit history around v1.1.1). To prevent
+        // a regression, reject any call site that supplies a third argument to
+        // World.spawn(Location, Class, ...). The portable two-argument form is fine.
+        val pattern = Regex("""\.spawn\s*\(\s*[^)]*\.class\s*,\s*[A-Za-z_]""")
+        val violations = mutableListOf<String>()
+        sourceFiles(
+            "src/main/java",
+            "src/main/kotlin"
+        ).forEach { file ->
+            val text = Files.readString(file)
+            // Slice line by line so the violation report points at the offending site.
+            text.lineSequence().forEachIndexed { index, line ->
+                if (pattern.containsMatchIn(line)) {
+                    violations += "${projectRoot.relativize(file)}:${index + 1}: $line"
+                }
+            }
+        }
+
+        assertTrue(
+            violations.isEmpty(),
+            "Use World.spawn(Location, Class) and configure the entity afterwards; the Consumer overload was removed in Paper 1.21:\n${violations.joinToString("\n")}"
+        )
+    }
+
     private companion object {
         data class LineBudget(val path: String, val maxLines: Int)
         data class PublicMethodBudget(val path: String, val maxPublicMembers: Int)