fix: stop calling removed World.spawn Consumer overload on Paper 1.21+

The 1.1.0 jar was unusable on Paper 1.21.x: every render tick threw
NoSuchMethodError pointing at World.spawn(Location, Class,
org.bukkit.util.Consumer). The 1.20.1 paper-api dev bundle still
declares that deprecated org.bukkit.util.Consumer overload, so our
lambdas were resolved against it at compile time. Paper 1.21 actually
honoured the forRemoval marker and deleted the method, leaving the
shipped class file pointing at a method that no longer exists.

The Paper 1.21+ replacement uses java.util.function.Consumer, but we
cannot rely on either type being present everywhere in the supported
1.20.1 -> 26.x range. The smallest portable fix is to drop the Consumer
overload entirely and use the long-stable two-argument
World.spawn(Location, Class), then configure the entity immediately
afterwards.

- Convert all four spawn helpers (item display, text label, interaction
  hitbox, block display) to a two-step spawn: World.spawn(Location, Class)
  followed by the same property assignments that previously lived inside
  the consumer.
- Set setVisibleByDefault first so the entity tracker tick that picks the
  spawn up cannot broadcast a one-frame public-visibility window before
  the plugin narrows viewers.
- Bump the project version to 1.1.1 and add a CHANGELOG entry that
  describes the hotfix in both English and Simplified Chinese.

Verified: ./gradlew test (full suite) passes against the 1.20.1
baseline; the resulting jar no longer references the removed Consumer
overload, so deployment on Paper 1.21.x stops crashing per render tick.

Author: Arbousier1

CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 1.1.1 - 2026-06-16
+
+Hotfix release for Paper 1.21+ servers. 1.1.0 was unusable on Paper 1.21.x because every entity render path tripped a `NoSuchMethodError`.
+
+中文更新日志:
+
+- Paper 1.21+ 渲染崩溃修复: 在 1.21 上每次刷新桌面渲染都会抛 `NoSuchMethodError: org.bukkit.World.spawn(Location, Class, org.bukkit.util.Consumer)`，因为 Paper 1.21 已经移除了已弃用的 `org.bukkit.util.Consumer` 重载，而 1.20 的开发包让 lambda 在编译期被解析到这个 forRemoval 的方法上。改成两步 spawn（先 `World.spawn(Location, Class)`，再立即配置实体）后，麻将牌、文本标签、交互盒和方块展示在 1.20.1-26.x 全版本上都能正常生成。
+- 可见性次序加固: spawn 之后第一时间设置 `setVisibleByDefault`，防止 entity tracker 在某些版本上抢先广播一帧默认可见状态。
+
+English Release Notes:
+
+- Paper 1.21+ render crash fix: every render tick threw `NoSuchMethodError: org.bukkit.World.spawn(Location, Class, org.bukkit.util.Consumer)` on Paper 1.21.x because Paper removed the deprecated `org.bukkit.util.Consumer` overload while the 1.20 dev bundle had bound our lambdas to it at compile time. The four entity factories (tile/label/interaction/block) now use the long-stable two-argument `World.spawn(Location, Class)` and configure the entity immediately afterwards, restoring rendering across the full 1.20.1-26.x range.
+- Visibility ordering hardening: `setVisibleByDefault` is now called first so the entity tracker cannot publish a one-frame window of default visibility before the plugin restricts viewers.
+
 ## 1.1.0 - 2026-06-16
 
 Compatibility and architecture release for the post-1.0.0 Paper/Folia line.

build.gradle.kts

@@ -14,7 +14,7 @@ plugins {
 }
 
 group = "top.ellan"
-version = "1.1.0"
+version = "1.1.1"
 
 val minimumPaperDevBundleVersion = "1.20.1-R0.1-SNAPSHOT"
 val latestPaperDevBundleVersion = "26.2-rc-2.build.9-alpha"

src/main/java/top/ellan/mahjong/render/display/DisplayEntities.java

@@ -654,37 +654,44 @@ private static ItemDisplay spawnTileDisplayInternal(
             throw new IllegalArgumentException("Location world is null");
         }
 
-        ItemDisplay display = world.spawn(location, ItemDisplay.class, spawned -> {
-            boolean restrictedVisibility = privateViewers != null;
-            spawned.setPersistent(false);
-            markManagedEntity(runtime.bukkitPlugin(), spawned);
-            spawned.setItemDisplayTransform(ItemDisplay.ItemDisplayTransform.HEAD);
-            spawned.setInterpolationDuration(smoothMovement ? 1 : 0);
-            spawned.setInterpolationDelay(0);
-            PaperCompatibility.setTeleportDuration(spawned, smoothMovement ? 1 : 0);
-            spawned.setViewRange(32.0F);
-            spawned.setShadowRadius(0.0F);
-            spawned.setShadowStrength(0.0F);
-            spawned.setDisplayWidth(0.4F * scale);
-            spawned.setDisplayHeight(0.6F * scale);
-            if (billboard != null) {
-                spawned.setBillboard(billboard);
-            }
-            spawned.setRotation(yaw, 0.0F);
-            spawned.setVisibleByDefault(!restrictedVisibility && visibleByDefault);
-            if (glowColor != null) {
-                spawned.setGlowing(true);
-                spawned.setGlowColorOverride(glowColor);
-                spawned.setBrightness(new Display.Brightness(15, 15));
-            }
-            spawned.setTransformation(new Transformation(
-                new Vector3f(),
-                new AxisAngle4f((float) Math.toRadians(pose.xRotationDegrees()), 1.0F, 0.0F, 0.0F),
-                new Vector3f(scale, scale, scale),
-                new AxisAngle4f()
-            ));
-            spawned.setItemStack(tileItem(runtime, variant, tile, pose.faceDown()));
-        });
+        // World.spawn(Location, Class, Consumer) was source-compatible across 1.20.x but the
+        // Consumer parameter type changed from org.bukkit.util.Consumer (forRemoval) to
+        // java.util.function.Consumer in 1.21+. To keep one jar working on both we use the
+        // pre-1.20 World.spawn(Location, Class) entry point, which has been stable since
+        // Bukkit's earliest releases, and configure the entity immediately after spawning.
+        ItemDisplay display = world.spawn(location, ItemDisplay.class);
+        boolean restrictedVisibility = privateViewers != null;
+        // Set visibility before any other property so the entity tracker that
+        // wakes up on the next broadcast tick already sees the final state and
+        // never publishes a one-frame window of default visibility to clients.
+        display.setVisibleByDefault(!restrictedVisibility && visibleByDefault);
+        display.setPersistent(false);
+        markManagedEntity(runtime.bukkitPlugin(), display);
+        display.setItemDisplayTransform(ItemDisplay.ItemDisplayTransform.HEAD);
+        display.setInterpolationDuration(smoothMovement ? 1 : 0);
+        display.setInterpolationDelay(0);
+        PaperCompatibility.setTeleportDuration(display, smoothMovement ? 1 : 0);
+        display.setViewRange(32.0F);
+        display.setShadowRadius(0.0F);
+        display.setShadowStrength(0.0F);
+        display.setDisplayWidth(0.4F * scale);
+        display.setDisplayHeight(0.6F * scale);
+        if (billboard != null) {
+            display.setBillboard(billboard);
+        }
+        display.setRotation(yaw, 0.0F);
+        if (glowColor != null) {
+            display.setGlowing(true);
+            display.setGlowColorOverride(glowColor);
+            display.setBrightness(new Display.Brightness(15, 15));
+        }
+        display.setTransformation(new Transformation(
+            new Vector3f(),
+            new AxisAngle4f((float) Math.toRadians(pose.xRotationDegrees()), 1.0F, 0.0F, 0.0F),
+            new Vector3f(scale, scale, scale),
+            new AxisAngle4f()
+        ));
+        display.setItemStack(tileItem(runtime, variant, tile, pose.faceDown()));
 
         if (clickAction != null) {
             TableDisplayRegistry.register(display.getEntityId(), clickAction);
@@ -755,22 +762,23 @@ private static TextDisplay spawnLabel(
             throw new IllegalArgumentException("Location world is null");
         }
 
-        TextDisplay display = world.spawn(location, TextDisplay.class, spawned -> {
-            boolean privateOnly = privateViewers != null && !privateViewers.isEmpty();
-            spawned.setPersistent(false);
-            markManagedEntity(runtime.bukkitPlugin(), spawned);
-            spawned.text(text);
-            spawned.setSeeThrough(false);
-            spawned.setShadowed(shadowed);
-            spawned.setDefaultBackground(false);
-            spawned.setBillboard(billboard);
-            spawned.setRotation(yaw, pitch);
-            spawned.setLineWidth(160);
-            spawned.setViewRange(LABEL_VIEW_RANGE);
-            spawned.setBrightness(new Display.Brightness(15, 15));
-            spawned.setBackgroundColor(color);
-            spawned.setVisibleByDefault(!privateOnly);
-        });
+        TextDisplay display = world.spawn(location, TextDisplay.class);
+        boolean privateOnly = privateViewers != null && !privateViewers.isEmpty();
+        // See ItemDisplay spawn comment above: ensure the visibility flag is
+        // resolved before any tracker tick observes the entity.
+        display.setVisibleByDefault(!privateOnly);
+        display.setPersistent(false);
+        markManagedEntity(runtime.bukkitPlugin(), display);
+        display.text(text);
+        display.setSeeThrough(false);
+        display.setShadowed(shadowed);
+        display.setDefaultBackground(false);
+        display.setBillboard(billboard);
+        display.setRotation(yaw, pitch);
+        display.setLineWidth(160);
+        display.setViewRange(LABEL_VIEW_RANGE);
+        display.setBrightness(new Display.Brightness(15, 15));
+        display.setBackgroundColor(color);
         if (privateViewers != null && !privateViewers.isEmpty()) {
             DisplayVisibilityRegistry.registerPrivate(display.getEntityId(), privateViewers);
             syncPrivateVisibility(runtime, display, privateViewers);
@@ -812,15 +820,15 @@ private static Interaction spawnInteraction(
             throw new IllegalArgumentException("Location world is null");
         }
 
-        Interaction interaction = world.spawn(location, Interaction.class, spawned -> {
-            boolean privateOnly = privateViewers != null && !privateViewers.isEmpty();
-            spawned.setPersistent(false);
-            markManagedEntity(runtime.bukkitPlugin(), spawned);
-            spawned.setResponsive(true);
-            spawned.setInteractionWidth(width);
-            spawned.setInteractionHeight(height);
-            spawned.setVisibleByDefault(!privateOnly);
-        });
+        Interaction interaction = world.spawn(location, Interaction.class);
+        boolean interactionPrivateOnly = privateViewers != null && !privateViewers.isEmpty();
+        // See ItemDisplay spawn comment above.
+        interaction.setVisibleByDefault(!interactionPrivateOnly);
+        interaction.setPersistent(false);
+        markManagedEntity(runtime.bukkitPlugin(), interaction);
+        interaction.setResponsive(true);
+        interaction.setInteractionWidth(width);
+        interaction.setInteractionHeight(height);
         if (clickAction != null) {
             TableDisplayRegistry.register(interaction.getEntityId(), clickAction);
         }
@@ -866,29 +874,29 @@ public static BlockDisplay spawnBlockDisplay(
             throw new IllegalArgumentException("Location world is null");
         }
 
-        BlockDisplay display = world.spawn(location, BlockDisplay.class, spawned -> {
-            boolean privateOnly = privateViewers != null && !privateViewers.isEmpty();
-            spawned.setPersistent(false);
-            markManagedEntity(plugin, spawned);
-            spawned.setInterpolationDuration(1);
-            spawned.setInterpolationDelay(0);
-            PaperCompatibility.setTeleportDuration(spawned, 1);
-            spawned.setViewRange(48.0F);
-            spawned.setShadowRadius(0.0F);
-            spawned.setShadowStrength(0.0F);
-            spawned.setVisibleByDefault(!privateOnly && visibleByDefault);
-            spawned.setRotation(0.0F, 0.0F);
-            spawned.setBlock(material.createBlockData());
-            // Keep display hit volume aligned with visual scale so custom ray hit-testing is stable.
-            spawned.setDisplayWidth(scaleX);
-            spawned.setDisplayHeight(scaleY);
-            spawned.setTransformation(new Transformation(
-                new Vector3f(),
-                new AxisAngle4f(),
-                new Vector3f(scaleX, scaleY, scaleZ),
-                new AxisAngle4f()
-            ));
-        });
+        BlockDisplay display = world.spawn(location, BlockDisplay.class);
+        boolean blockPrivateOnly = privateViewers != null && !privateViewers.isEmpty();
+        // See ItemDisplay spawn comment above.
+        display.setVisibleByDefault(!blockPrivateOnly && visibleByDefault);
+        display.setPersistent(false);
+        markManagedEntity(plugin, display);
+        display.setInterpolationDuration(1);
+        display.setInterpolationDelay(0);
+        PaperCompatibility.setTeleportDuration(display, 1);
+        display.setViewRange(48.0F);
+        display.setShadowRadius(0.0F);
+        display.setShadowStrength(0.0F);
+        display.setRotation(0.0F, 0.0F);
+        display.setBlock(material.createBlockData());
+        // Keep display hit volume aligned with visual scale so custom ray hit-testing is stable.
+        display.setDisplayWidth(scaleX);
+        display.setDisplayHeight(scaleY);
+        display.setTransformation(new Transformation(
+            new Vector3f(),
+            new AxisAngle4f(),
+            new Vector3f(scaleX, scaleY, scaleZ),
+            new AxisAngle4f()
+        ));
         if (clickAction != null) {
             TableDisplayRegistry.register(display.getEntityId(), clickAction);
         }