perf: benchmark table region fingerprint hot path (#62)#62
Merged
Conversation
Arbousier1
force-pushed
the
codex/perf-region-benchmark
branch
from
July 16, 2026 05:38
586e182 to
0769c26
Compare
TypeThe0ry
marked this pull request as ready for review
July 16, 2026 05:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TableRegionFingerprintServicegc.alloc.rate.normfor both workloadsperformance-region-fingerprintworkflow/label routing and document the profileBehavior protection
The fixture uses the real
TableRenderSnapshotFactoryandTableRenderLayout. Before every JMH iteration it compares production results with an independent reference implementation of the currentObjects.toString(value, ""), colon-delimited, per-character FNV contract. It also fixes the exactDelimitedFingerprintBuilderoutput. These sentinels run outside the timed section, so a later candidate cannot pass by changing fingerprint semantics.The profile requires both primary time metrics to pass and treats allocation as a regression guardrail.
TableRegionFingerprintService.classis required during profile preflight. All benchmark/config/workflow paths remain protected by the existing base-owned gate.Scope
This is measurement infrastructure only. It does not modify
src/mainproduction behavior.Validation
git diff --cached --checkperf/ab/gate-config.jsonwith PowerShellConvertFrom-Json