Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Fully rewrote the C++ AI for Lord Gregor Lescovar, Marzon the Silent Blade, Spybot, and Tyrion to restore the complete retail‑accurate quest sequence.
Corrected escort path assignments:
Lescovar now uses DB path 14034 (Library → Platform)
Spybot now uses DB path 70850 (Platform → Library)
Fixed the dialogue phase logic:
Phase 4 no longer terminates the sequence prematurely
Phases 5–7 now execute correctly (Marzon + Lescovar conversation, quest credit, hostile phase)
Restored all missing NPC dialogues, including:
Guard interaction
Tyrion → Spybot → Tyriona sequence
Lescovar’s “Leave us.”
Marzon’s Defias conversation
Implemented proper quest credit (AreaExploredOrEventHappens) before the hostile phase.
Fixed guard despawn logic and synchronized it with Lescovar’s dialogue.
Improved summon handling, faction switching, and combat linking between Lescovar and Marzon.
Cleaned up AI state handling, timers, and GUID tracking for stability.
Target branch(es):
335/6x
Issues addressed: Fixes #
(Insert your issue number here)
Tests performed
✔ Builds successfully on TrinityCore 3.3.5a (latest master)
✔ Tested in‑game on a clean database
✔ Verified correct execution of:
✔Quest acceptance dialogue
✔Spybot movement + morph into Priestess Tyriona
✔Guard interaction
✔Lescovar escort path
✔Guard despawn event
✔Marzon spawn + movement
✔Full 3‑step conversation between Lescovar and Marzon
✔Quest credit awarded at correct moment
✔Both NPCs turning hostile after dialogue
✔ No Lua scripts required; pure C++ implementation
✔ No regressions found in Stormwind NPC behavior
Known issues and TODO list:
None. Script is working 100% well.