Create smaller modules for each functionality

Author: aliirdn

lib/options.js

@@ -0,0 +1,20 @@
+function Options(options) {
+    options = options || {};
+
+    this._defaultOptions = {
+        replaceNodeKill: true,
+        warmUp: false
+    };
+
+    this._options = Object.assign({}, this._defaultOptions, options);
+};
+
+Options.prototype.get = function (id) {
+    if (this._options.hasOwnProperty(id)) {
+        return this._options[id];
+    }
+
+    return null;
+}
+
+module.exports = Options;

lib/signals.js

@@ -0,0 +1,20 @@
+function Signals() {
+    this._supportedSignals = {
+        'SIGBREAK': 1,
+        'SIGINT': 2
+    }
+}
+
+Signals.prototype.isSupported = function (signal) {
+    return this._supportedSignals.hasOwnProperty(signal);
+}
+
+Signals.prototype.idToNumber = function (signal) {
+    if (this._supportedSignals.hasOwnProperty(signal)) {
+        return this._supportedSignals[signal];
+    }
+
+    return null;
+}
+
+module.exports = Signals;

lib/windows-kill-class.js

@@ -1,40 +1,28 @@
+var path = require('path');
+
 var binary = require('node-pre-gyp');
-var path = require('path')
-var bindingPath = binary.find(path.resolve(path.join(__dirname, '../package.json')));
 
-var supportedSignals = [
-    'SIGBREAK',
-    'SIGINT'
-];
+var bindingPath = binary.find(path.resolve(path.join(__dirname, '../package.json')));
 
-var supportedSignalsAsNumber = {
-    'SIGBREAK': 1,
-    'SIGINT': 2
-}
+var Options = require('./options');
+var Signals = require('./signals');
 
 function WindowsKillClass(options) {
     this._native = require(bindingPath);
     this._nodeKill = process.kill;
 
-    this._shouldReplaceNodesKill = true;
-    if (options && options.hasOwnProperty('replaceNodeKill') && (options.replaceNodeKill === false || options.replaceNodeKill === true)) {
-        this._shouldReplaceNodesKill = options.replaceNodeKill;
-    }
-
-    this._shouldWarmUp = false;
-    if (options && options.hasOwnProperty('warmUp') && (options.warmUp === false || options.warmUp === true)) {
-        this._shouldWarmUp = options.warmUp;
-    }
+    this._options = new Options(options);
+    this._signals = new Signals();
 
     this._applyOptions();
 };
 
 WindowsKillClass.prototype._applyOptions = function () {
-    if (this._shouldReplaceNodesKill) {
+    if (this._options.get('replaceNodeKill') === true) {
         this._replaceNodeKill();
     }
 
-    if (this._shouldWarmUp) {
+    if (this._options.get('warmUp') === true) {
         this._native.warmUp();
     }
 }
@@ -47,12 +35,13 @@ WindowsKillClass.prototype._replaceNodeKill = function () {
 }
 
 WindowsKillClass.prototype.kill = function (pid, signal) {
-    if (supportedSignals.indexOf(signal) >= 0) {
+    if (this._signals.isSupported(signal)) {
         if (pid != (pid | 0)) {
             throw new TypeError('invalid pid.');
         }
 
-        error = this._native.send(pid, supportedSignalsAsNumber[signal]);
+        error = this._native.send(pid, this._signals.idToNumber(signal));
+
         if (error) {
             throw new Error('windows-kill ' + error);
         }