Fix empty answers from pending user-input auto-advance#114
Merged
Emanuele-web04 merged 3 commits intoMay 14, 2026
Merged
Conversation
The single-select auto-advance timer captured onAdvance in a useCallback closure, so the deferred 200ms submit fired with a stale activePendingResolvedAnswers and sent empty answers to the provider. Track the latest onAdvance in a ref and make handleOptionSelection a useEffectEvent so the deferred submit always uses current answer state.
github-actions
Bot
added
size:M
vouch:trusted
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13433c4bd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A manual Next/Submit landing inside the 200ms auto-advance window left an outstanding timer that fired against the latest onAdvance, skipping a question or submitting a second time. Re-key the cleanup effect on the active question id and isResponding so the timer is cancelled whenever the prompt moves on without it.
Marve10s
changed the title
Marve10s
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an agent asks questions in interactive/plan mode and the user picks an answer, the provider often receives empty answers instead of the selected ones.
Cause
In
ComposerPendingUserInputPanel.tsx,handleOptionSelectionwas auseCallbackwhosesetTimeout(..., 200)auto-advance callback capturedonAdvanceat creation time. On selecting a single-select option:onToggleOptionschedules the state update with the pick.onAdvance.onAdvance, whoseactivePendingResolvedAnswersisnull/partial.Fix
Mirrors the working implementation in the upstream reference repo:
onAdvanceinonAdvanceRef, kept current via an effect.handleOptionSelectionauseEffectEventso it always sees current props/state.onAdvanceRef.current(), so the submit always uses up-to-date answer state.Scoped to a single file; no behavior change for multi-select or keyboard paths.