Fix model picker breaking when Cursor CLI is unavailable#117
Open
Zeus-Deus wants to merge 1 commit into
Open
Conversation
Model discovery runs per provider, but a failing CLI rejected the whole query and left the shared model picker stuck in a loading/error state instead of degrading only that provider. - Catch discovery failures in providerModelsQueryOptions and resolve to an empty result, so one provider's failure no longer blanks the picker. Every other provider keeps its own models. - Gate the Cursor/Kilo discovery skeleton on isLoading so background refetches don't re-blank the picker once discovery has settled. - Add coverage proving a single provider failure doesn't affect the others, and fix a missing kilo key in an existing test fixture. Fixes Emanuele-web04#103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
When the Cursor CLI isn't installed or authenticated, Cursor's model discovery fails — and that failure was rejecting the whole models query, leaving the model picker stuck in a loading/error state for every provider.
Changes
providerModelsQueryOptionsnow catches discovery failures and resolves to an empty result instead of rejecting. A failing CLI degrades only that provider; every other provider keeps its models.isLoadinginstead ofisFetching, so background refetches don't re-blank the picker once discovery has settled.kilokey in an existing test fixture.Testing
bun lintandbun run testpass.Note:
bun typecheckstill reports one pre-existing, unrelated error incomposerDraftStore.ts(Pi provider), and two server tests fail for environment reasons — both already present onmainand untouched here.