Disable mouse reporting on terminal reattach#118
Open
Zeus-Deus wants to merge 1 commit into
Open
Conversation
Restored terminal panes could come back with mouse reporting still on. With no TUI attached to consume the events, moving the mouse printed raw CSI escape sequences into the shell, and reset/stty sane didn't fix it. The server now appends a mouse-mode reset to the history returned in a terminal snapshot, so it's applied whenever a terminal is opened, reattached, or restored. The web side also clears mouse-tracking modes when replaying a snapshot, since xterm.js doesn't reliably clear them on a full reset. Added unit tests for the reattach and restore paths.
github-actions
Bot
added
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
Restored terminal panes could come back with mouse reporting still on. With no TUI attached to consume the events, moving the mouse printed raw CSI escape sequences into the shell, and reset/stty sane didn't fix it.
The server now appends a mouse-mode reset to the history returned in a terminal snapshot, so it's applied whenever a terminal is opened, reattached, or restored. The web side also clears mouse-tracking modes when replaying a snapshot, since xterm.js doesn't reliably clear them on a full reset. Both sides share one constant for the reset sequence.
Added unit tests for the reattach and restore paths. Also checked it in a running app — after a reconnect and snapshot replay, mouse movement over a restored terminal no longer prints escape sequences.