Add provider auto-update flow#119
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cfe4229a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
| } | ||
| return yield* resolveProviderMaintenanceCapabilitiesEffect(definition, { | ||
| binaryPath: getProviderBinaryPath(provider, settings), |
There was a problem hiding this comment.
Probe the same binary used for update advisories
When a user configures a provider CLI override, the update capability is resolved from that configured path here, but the status.version that enrichProviderStatusWithVersionAdvisory compares still comes from the hard-coded health probes (runCodexCommand, runClaudeCommand, etc. spawn literal codex, claude, gemini, ...). In that configuration the UI can compare the PATH installation's version against the configured binary's update source/command, causing false outdated warnings or an unchanged result after updating the configured binary. The version probe and update capability resolution should use the same executable.
Useful? React with 👍 / 👎.
Summary
Validation