Fix model picker loading state during initial discovery#121
Open
Zeus-Deus wants to merge 1 commit into
Open
Conversation
The discovery skeleton was gated on isLoading, but providerModelsQueryOptions uses placeholderData, which keeps the query in "success" status during its first fetch — so isLoading is never true there. Initial discovery skipped the skeleton and briefly showed static fallback models while the CLI was still being queried. Add isInitialModelDiscoveryPending (isFetching && isPlaceholderData) so the initial fetch is caught without re-gating on background refetches, and use it for both the Cursor and Kilo gates. Also trim the comments from Emanuele-web04#117 and add a test covering the initial-fetch vs refetch behavior.
github-actions
Bot
added
size:M
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #117.
The discovery skeleton was gated on
isLoading, butproviderModelsQueryOptionsusesplaceholderData, which keeps the query in "success" status on its first fetch — soisLoadingis never true there. Initial discovery skipped the skeleton and briefly showed the static fallback models while the CLI was still being queried.Added
isInitialModelDiscoveryPending(isFetching && isPlaceholderData) so the initial fetch is caught without re-gating on background refetches, and used it for both the Cursor and Kilo gates.Also addressed the rest of the review on #117: