vscode: switch S to UNPACKDIR for whinlatter+#3
Merged
Conversation
Whinlatter and wrynose split WORKDIR and UNPACKDIR; do_unpack
extracts under UNPACKDIR while WORKDIR is reserved for build
artefacts. The recipe used to set S = ${WORKDIR}/VSCode-linux-...
which now produces 'S should be set relative to UNPACKDIR' as a
fatal error.
Switch to S = ${UNPACKDIR}/... with a kirkstone..walnascar
fallback via UNPACKDIR ??= ${WORKDIR} so older releases that
don't define UNPACKDIR keep working.
The first cut at this fix set UNPACKDIR ??= ${WORKDIR} so kirkstone /
scarthgap (which don't define UNPACKDIR) would still work, but
bitbake.conf on styhead+ rejects the literal 'UNPACKDIR = ${WORKDIR}'
assignment ('Using UNPACKDIR = ${WORKDIR} is not supported').
Compute the prefix via a Python expression instead: use UNPACKDIR if
the release has set one, fall back to WORKDIR otherwise. Same end
result on every supported release without tripping the assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whinlatter and wrynose split WORKDIR and UNPACKDIR —
do_unpackextracts under UNPACKDIR, while WORKDIR is now reserved for build artefacts. The recipe was setting S to a path under WORKDIR which now produces a fatal error: "S should be set relative to UNPACKDIR".Caught by the per-release CI sweep on the whinlatter and wrynose branches.
Fix: switch S to
${UNPACKDIR}/VSCode-linux-${VSCODE_ARCH}, with aUNPACKDIR ??= "${WORKDIR}"fallback so kirkstone..walnascar (which don't define UNPACKDIR) keep working.