Created noThrow Wrapper for which(), Fixed Arch Map for MSVC

[diefbell-grabcad]

When trying to build ZeroMQ.js, I got the error [ERROR cmake-ts] Error: not found: ninja. It seems that this is caused by the nothrow option not being respected here

cmake-ts/src/generator.ts

Line 18 in 44d3794

const ninja = await which("ninja", { nothrow: true })

.

There was some discussion regarding this on the node-which repo, seems the issue is fixed in v3+: npm/node-which#80. However this would require bumping the required Node version.

Instead, I've just created a whichNoThrow function to handle catching and returning null.

There was also an issue in argumentBuilder.ts where cmakeArchMap.win32.x64 was mapping incorrectly to "AMD64", but MSVC expects "x64". I'm not sure though if this breaks other Windows build tools... Can check with CI?

Please also add into ZeroMQ after merge ^_^

[diefbell-grabcad]

pnpm add which@3.0.1 decided it needed to reformat the entire file

[diefbell-grabcad]

Which then made linting fail 🤦

[aminya]

No problem. I can fix that

[aminya]

Thanks for the change. However, since cmake-ts is a build tool that can be used on older Nodejs to build binaries, we want to keep the code compatible with old versions. Does this update break compatibility?

We can create our own which nothrow, if that's the only reason for the bump. Alternatively, we can add polyfils to maintain compatibility.

[aminya]

Any reason to change this? I tested it when I created this to make sure it works.

[diefbell-grabcad]

@aminya One year later, I've made the change, as requested :')

[aminya]

@aminya One year later, I've made the change, as requested :')

I completely forgot about this. Haha. It's great you made the changes. I'll test in the coming days.

[diefbell-grabcad]

I was thinking that we perhaps want to add an MSVC test to the workflows, such as with https://github.com/ilammy/msvc-dev-cmd