Implement PackedGuid

Not actually tested yet, so could have mistakes

Author: Chaosvex

src/libs/protocol/CMakeLists.txt

@@ -75,6 +75,10 @@ set(SERVER_MESSAGES
     include/protocol/server/NewWorld.h
 )
 
+set(TYPE_HEADERS
+    include/protocol/types/PackedGuid.h
+)
+
 set(CORE_HEADERS
     include/protocol/Deserialise.h
     include/protocol/Opcodes.h
@@ -92,6 +96,7 @@ set(CORE_HEADERS
 set(HEADERS
     ${CLIENT_MESSAGES}
     ${SERVER_MESSAGES}
+	${TYPE_HEADERS}
     ${CORE_HEADERS}
 )
 

src/libs/protocol/include/protocol/server/GenericMove.h

@@ -12,13 +12,14 @@
 #include <protocol/StreamResult.h>
 #include <protocol/ResultCodes.h>
 #include <protocol/MovementInfo.h>
+#include <protocol/types/PackedGuid.h>
 #include <stdexcept>
 #include <cstdint>
 
 namespace ember::protocol::server {
 
 struct GenericMove final {
-	std::uint64_t guid;
+	PackedGuid guid;
 	MovementInfo info;
 
 	StreamResult read_from_stream(le_stream auto& stream) {

src/libs/protocol/include/protocol/server/MoveFallLand.h

@@ -12,13 +12,14 @@
 #include <protocol/StreamResult.h>
 #include <protocol/ResultCodes.h>
 #include <protocol/MovementInfo.h>
+#include <protocol/types/PackedGuid.h>
 #include <stdexcept>
 #include <cstdint>
 
 namespace ember::protocol::server {
 
 struct MoveFallLand final {
-	std::uint64_t guid;
+	PackedGuid guid;
 	MovementInfo info;
 
 	StreamResult read_from_stream(le_stream auto& stream) {

src/libs/protocol/include/protocol/server/MoveTimeSkipped.h

@@ -11,13 +11,14 @@
 #include <protocol/Concepts.h>
 #include <protocol/StreamResult.h>
 #include <protocol/ResultCodes.h>
+#include <protocol/types/PackedGuid.h>
 #include <stdexcept>
 #include <cstdint>
 
 namespace ember::protocol::server {
 
 struct MoveTimeSkipped final {
-	std::uint64_t guid;
+	PackedGuid guid;
 	std::uint32_t lag;
 
 	StreamResult read_from_stream(le_stream auto& stream) {

src/libs/protocol/include/protocol/server/SplineMoveSetWalkMode.h

@@ -11,14 +11,15 @@
 #include <protocol/Concepts.h>
 #include <protocol/StreamResult.h>
 #include <protocol/ResultCodes.h>
+#include <protocol/types/PackedGuid.h>
 #include <array>
 #include <stdexcept>
 #include <cstdint>
 
 namespace ember::protocol::server {
 
 struct SplineMoveSetWalkMode final {
-	std::uint64_t guid;
+	PackedGuid guid;
 
 	StreamResult read_from_stream(le_stream auto& stream) {
 		stream >> guid;

src/libs/protocol/include/protocol/types/PackedGuid.h

@@ -0,0 +1,97 @@
+/*
+ * Copyright (c) 2026 Ember
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include <bit>
+#include <climits>
+#include <cstdint>
+
+namespace ember::protocol {
+
+using Guid = std::uint64_t; // temp
+
+struct PackedGuid {
+	Guid guid = 0;
+
+	PackedGuid() = default;
+
+	explicit PackedGuid(Guid value)
+		: guid(value) {}
+
+	PackedGuid& operator=(Guid value) {
+		guid = value;
+		return *this;
+	}
+
+	auto& operator<<(auto& stream) const {
+		// produce the mask
+		std::uint8_t mask = 0;
+		std::uint8_t set = 0;
+
+		for(auto i = 0; i < sizeof(std::uint64_t); ++i) {
+			const auto seg_mask = static_cast<std::uint64_t>(0xff) << (i * CHAR_BIT);
+
+			if(guid & seg_mask) {
+				mask |= (1 << i);
+				++set;
+			}
+		}
+
+		stream << mask;
+
+		// send the set bytes
+		std::uint8_t sent = 0;
+
+		for(auto i = 0; i < sizeof(std::uint64_t); ++i) {
+			const auto byte = static_cast<std::uint8_t>((guid >> (i * CHAR_BIT)) & 0xff);
+
+			if(!byte) {
+				continue;
+			}
+
+			stream << byte;
+			
+			if(++sent == set) {
+				break;
+			}
+		}
+
+		return stream;
+	}
+
+	auto& operator>>(auto& stream) {
+		const std::uint8_t mask;
+		stream >> mask;
+
+		const auto count = std::popcount(mask);
+
+		if(count == CHAR_BIT) {
+			stream >> guid;
+			return stream;
+		}
+
+		std::uint8_t bits_set = 0;
+
+		for(auto i = 0; i < CHAR_BIT; ++i) {
+			if(mask & (1 << i)) {
+				std::uint8_t byte;
+				stream >> byte;
+				guid |= (static_cast<std::uint64_t>(byte) << (i * CHAR_BIT));
+
+				if(++bits_set == count) {
+					break;
+				}
+			}
+		}
+
+		return stream;
+	}
+};
+
+} // protocol, ember

src/realm/states/WorldEnter.cpp

@@ -227,11 +227,6 @@ void handle_move_fall_land(ClientContext& ctx) {
 	if(auto result = protocol::deserialise(packet, ctx.stream()); !result) {
 		return ctx.stream_err(result);
 	}
-
-	protocol::move_fall_land_s response;
-	response->guid = packed_guid;
-	response->info = packet->info;
-	ctx.send(response);
 }
 
 void handle_move_set_facing(ClientContext& ctx) {
@@ -240,11 +235,6 @@ void handle_move_set_facing(ClientContext& ctx) {
 	if(auto result = protocol::deserialise(packet, ctx.stream()); !result) {
 		return ctx.stream_err(result);
 	}
-
-	protocol::msg_move_set_facing_s response;
-	response->guid = packed_guid;
-	response->info = packet->info;
-	ctx.send(response);
 }
 
 void handle_zone_update(ClientContext& ctx) {