fix(quality): more stuff

Author: CodeMeAPixel

.github/README.md

@@ -47,7 +47,7 @@ Emberly is an open source platform for modern file storage, sharing, and identit
 - Promo code management with configurable discounts
 - User management dashboard
 - Application review queue with multi stage triage
-- Service status monitoring via Kener integration
+- Service status page link ([emberlystat.us](https://emberlystat.us))
 - Analytics and usage reporting
 
 ## Quick Start
@@ -105,7 +105,6 @@ The application will be available at http://localhost:3000.
 **Infrastructure & Services**
 
 - [S3 compatible storage](https://aws.amazon.com/s3/) - File storage
-- [Kener](https://kener.ing/) - Status page monitoring
 - [Next.js Auth](https://next-auth.js.org/) - Authentication
 - [Sentry](https://sentry.io/) - Error tracking
 
@@ -176,7 +175,6 @@ Get help and connect with the community:
 
 This project is licensed under the GNU Affero General Public License v3 (AGPL-3.0). See the [LICENSE](LICENSE) file for details.
 
-
 ## Code of Conduct
 
 This project adheres to the Contributor Covenant Code of Conduct. By participating, you agree to uphold this code. See [CODE_OF_CONDUCT.md](CODE_OF_CONDUCT.md) for the full text.
@@ -185,7 +183,6 @@ This project adheres to the Contributor Covenant Code of Conduct. By participati
 
 Thank you to all [contributors](https://github.com/EmberlyOSS/Emberly/graphs/contributors) who have helped make Emberly possible. We also appreciate the [open source projects and communities](https://github.com/EmberlyOSS/Emberly/network/dependencies) that make Emberly possible.
 
-
 <a href="https://github.com/EmberlyOSS/Emberly/graphs/contributors">
   <img src="https://contrib.rocks/image?repo=EmberlyOSS/Emberly" alt="Contributors" />
 </a>

CHANGELOG.md

@@ -25,7 +25,7 @@ The format is based on "Keep a Changelog" and follows [Semantic Versioning](http
 ### Changed
 
 - **Status Page Integration Removed**
-  - Removed the Kener / Uptime Kuma dynamic status integration entirely. The polling logic, `/api/status` route, admin settings panel, and integration test handler have all been removed.
+  - Removed the Kener / Uptime Kuma dynamic status integration entirely. The polling logic, `/api/status` route (now returns 404), admin settings panel, and integration test handler have all been removed.
   - `StatusIndicator` in the site footer is now a lightweight static link to [emberlystat.us](https://emberlystat.us) — no external API calls, no runtime failures, no "Status unknown" states.
   - `KENER_API_KEY`, `KENER_BASE_URL`, `UPTIME_KUMA_BASE_URL`, and `UPTIME_KUMA_SLUG` environment variables are no longer used and can be removed.
 
@@ -53,6 +53,13 @@ The format is based on "Keep a Changelog" and follows [Semantic Versioning](http
 - **ESLint — Empty interfaces in `react-jsx-compat.d.ts`** — Six `interface X extends Y {}` declarations with no added members replaced with `type X = Y` aliases, satisfying `@typescript-eslint/no-empty-object-type`.
 - **ESLint — Unused variables across multiple files** — Removed or prefixed unused imports and variables flagged by `@typescript-eslint/no-unused-vars`: `Copy` in `bucket/page.tsx`, `User` in `blog/page.tsx`, `Share2`/`User` in `blog/[slug]/page.tsx`, `Footer`/`getConfig`/`providedPassword` in `[filename]/page.tsx`, `toast` in `squads/client.tsx`, `codeSent` state in `alpha-migration/page.tsx`, and `userName` parameter in `dashboard/client.tsx`.
 - **ESLint — `let` → `const` in `theme-initializer.tsx`** — `cssVariables` was declared with `let` but never reassigned; declaration moved to the single assignment site as `const`.
+- **Integration test fetch timeouts** — `testStripe`, `testResend`, `testCloudflare`, `testDiscord` (bot + webhook), and `testGitHub` had no request timeout, allowing the admin integration-test endpoint to hang indefinitely if a provider didn't respond. All now use `AbortSignal.timeout(8000)`, consistent with the existing Vultr handler.
+- **Quarantine failure logging** — `Promise.allSettled` results in the VirusTotal quarantine path were silently discarded. Storage delete or DB update failures now log an error with the file ID so they can be investigated.
+- **Session cache `emailVerified` backfill** — Redis-cached sessions written before the `emailVerified: boolean` field was added would deserialize with `undefined`, breaking the upload auth contract. A coerce-on-read now sets `false` for any entry missing the field.
+- **Legacy `kener`/`uptimeKuma` config keys stripped from admin response** — The integration config schema uses `.passthrough()`, so old DB records containing stale Kener or Uptime Kuma keys would survive `deepMerge` and be returned to SUPERADMIN via `GET /api/settings`. `maskSecretsForAdmin` now explicitly deletes both keys before returning.
+- **Empty filename slug fallback** — Filenames composed entirely of non-ASCII/symbol characters would reduce to an empty slug after sanitization, producing broken storage paths. A `nanoid(6)` fallback is now used when the slug is empty.
+- **`storageQuotaMB = 0` admin override ignored** — `if (!baseQuotaMB)` treated an explicit zero-quota override as "unset", falling through to plan-based quota. Changed to `== null` checks so `0` is honored as a deliberate override.
+- **Storage-bucket subscription precedence missing from Stripe re-check path** — After a successful Stripe sync, `getPlanLimits` returned the latest active subscription without first checking for a `storage-bucket-*` subscription. Users with both sub types active could receive non-unlimited limits for that request. The re-check now mirrors the original early-exit logic.
 
 ## [2.4.5] - 2026-06-02
 

app/api/admin/integrations/test/route.ts

@@ -60,6 +60,7 @@ async function testStripe(secretKey: string): Promise<TestResult> {
   try {
     const res = await fetch('https://api.stripe.com/v1/customers?limit=1', {
       headers: { Authorization: `Bearer ${secretKey}` },
+      signal: AbortSignal.timeout(8000),
     })
     if (res.status === 401)
       return {
@@ -84,6 +85,7 @@ async function testResend(apiKey: string): Promise<TestResult> {
   try {
     const res = await fetch('https://api.resend.com/domains', {
       headers: { Authorization: `Bearer ${apiKey}` },
+      signal: AbortSignal.timeout(8000),
     })
     if (res.status === 401 || res.status === 403)
       return { ok: false, message: 'Invalid API key' }
@@ -125,6 +127,7 @@ async function testCloudflare(
         Authorization: `Bearer ${apiToken}`,
         'Content-Type': 'application/json',
       },
+      signal: AbortSignal.timeout(8000),
     })
     const json = await res.json().catch(() => null)
     if (!res.ok || json?.success === false) {
@@ -168,6 +171,7 @@ async function testDiscord(
         `https://discord.com/api/v10/guilds/${safeServerId}`,
         {
           headers: { Authorization: `Bot ${botToken}` },
+          signal: AbortSignal.timeout(8000),
         }
       )
       if (res.status === 401) return { ok: false, message: 'Invalid bot token' }
@@ -226,7 +230,10 @@ async function testDiscord(
       const [, webhookId, webhookToken] = match
       const safeWebhookUrl = `https://discord.com/api/webhooks/${encodeURIComponent(webhookId)}/${encodeURIComponent(webhookToken)}`
 
-      const res = await fetch(safeWebhookUrl, { method: 'GET' })
+      const res = await fetch(safeWebhookUrl, {
+        method: 'GET',
+        signal: AbortSignal.timeout(8000),
+      })
       if (res.status === 401)
         return { ok: false, message: 'Invalid webhook URL' }
       if (!res.ok)
@@ -270,6 +277,7 @@ async function testGitHub(pat: string, org?: string): Promise<TestResult> {
         Accept: 'application/vnd.github+json',
         'X-GitHub-Api-Version': '2022-11-28',
       },
+      signal: AbortSignal.timeout(8000),
     })
     if (res.status === 401)
       return { ok: false, message: 'Invalid personal access token' }

app/api/files/route.ts

@@ -279,13 +279,22 @@ export async function POST(req: Request) {
         permalink: vtResult.permalink,
         userId: user.id,
       })
-      await Promise.allSettled([
+      const results = await Promise.allSettled([
         storageProvider!.deleteFile(filePath),
         prisma.file.update({
           where: { id: fileRecord.id },
           data: { visibility: 'PRIVATE', name: '[Quarantined]' },
         }),
       ])
+      results.forEach((r, i) => {
+        if (r.status === 'rejected') {
+          logger.error(
+            `Quarantine step ${i === 0 ? 'storage delete' : 'db update'} failed`,
+            r.reason as Error,
+            { fileId: fileRecord.id }
+          )
+        }
+      })
     }).catch((err) => {
       logger.error('Background VirusTotal scan failed', err as Error, {
         fileId: fileRecord.id,

app/api/settings/route.ts

@@ -5,10 +5,7 @@ import {
 } from '@/packages/types/dto/settings'
 
 import { HTTP_STATUS, apiError, apiResponse } from '@/packages/lib/api/response'
-import {
-  requireAuth,
-  requireSuperAdmin,
-} from '@/packages/lib/auth/api-auth'
+import { requireAuth, requireSuperAdmin } from '@/packages/lib/auth/api-auth'
 import {
   EmberlyConfig,
   getConfig,
@@ -50,6 +47,9 @@ function maskSecretsForAdmin(config: EmberlyConfig): EmberlyConfig {
   if (i.github) {
     i.github.pat = ''
   }
+  // Remove any stale legacy integration keys that may still live in DB config
+  delete i.kener
+  delete i.uptimeKuma
   return c as EmberlyConfig
 }
 

packages/lib/cache/session-cache.ts

@@ -39,7 +39,12 @@ export const sessionCache = {
       const redis = await getRedisClient()
       const data = await redis.get(redisKeys.userSession(userId))
       if (!data) return null
-      return JSON.parse(data) as CachedUserSession
+      const parsed = JSON.parse(data) as CachedUserSession
+      // Coerce emailVerified for older cached entries that pre-date the boolean field
+      if (typeof parsed.emailVerified !== 'boolean') {
+        parsed.emailVerified = false
+      }
+      return parsed
     } catch (error) {
       logger.error('Failed to get cached user session', error as Error, {
         userId,

packages/lib/files/filename.ts

@@ -101,6 +101,7 @@ export async function getUniqueFilename(
   while (s < e && urlSafeName[s] === '-') s++
   while (e > s && urlSafeName[e - 1] === '-') e--
   urlSafeName = urlSafeName.slice(s, e)
+  if (!urlSafeName) urlSafeName = nanoid(6)
 
   if (extension) {
     urlSafeName += '.' + extension.toLowerCase()

packages/lib/storage/quota.ts

@@ -112,7 +112,23 @@ export async function getPlanLimits(userId: string): Promise<PlanLimits> {
           userId,
           userRecord.stripeCustomerId
         )
-        // Re-check after sync
+        // Re-check after sync — storage-bucket subs take precedence (unlimited)
+        const syncedBucketSub = await prisma.subscription.findFirst({
+          where: {
+            userId,
+            status: 'active',
+            product: { slug: { startsWith: 'storage-bucket' } },
+          },
+          select: { id: true },
+        })
+        if (syncedBucketSub) {
+          return {
+            storageQuotaGB: null,
+            uploadSizeCapMB: null,
+            customDomainsLimit: null,
+            planName: 'Storage Bucket (Unlimited)',
+          }
+        }
         const syncedSub = await prisma.subscription.findFirst({
           where: { userId, status: 'active' },
           include: { product: true },
@@ -252,15 +268,15 @@ export async function getEffectiveQuotaMB(
 
   // Priority: admin override > plan quota + perks > default quota
   let baseQuotaMB = user.storageQuotaMB
-  if (!baseQuotaMB) {
+  if (baseQuotaMB == null) {
     if (planLimits.storageQuotaGB === null) {
       // Unlimited plan — use a 100 TB sentinel so arithmetic still works
       baseQuotaMB = 100 * 1024 * 1024
     } else {
       baseQuotaMB = (planLimits.storageQuotaGB + perkStorageBonusGB) * 1024
     }
   }
-  if (!baseQuotaMB && defaultQuotaMB) {
+  if (baseQuotaMB == null && defaultQuotaMB != null) {
     baseQuotaMB = defaultQuotaMB
   }