Snowlake table wrapper#31
Merged
Merged
Conversation
rampage644
reviewed
Nov 21, 2025
rampage644
reviewed
Nov 21, 2025
|
|
||
| let table_provider: Arc<dyn TableProvider> = | ||
| Arc::new(IcebergDataFusionTable::new(tabular, None, None, None)); | ||
| Arc::new(SnowflakeCaseInsensitiveTable::new(Arc::new( |
Contributor
There was a problem hiding this comment.
Does it apply to all tables? Question if s3 table buckets still work in this case?
rampage644
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added TableProvider adapter that rewrites column names to match Snowflake's case-insensitive semantics.
Snowflake stores schemas in uppercase, while queries are typically written in lowercase. DataFusion treats identifiers as case-sensitive, which causes mismatches between the logical projection expressions (lowercase) and the physical input schema (uppercase). This adapter: