Skip to content

service: Simple read only mode#38

Merged
DanCodedThis merged 6 commits into
mainfrom
DanCodedThis/read-only-mode
Nov 24, 2025
Merged

service: Simple read only mode#38
DanCodedThis merged 6 commits into
mainfrom
DanCodedThis/read-only-mode

Conversation

@DanCodedThis
Copy link
Copy Markdown
Contributor

@DanCodedThis DanCodedThis commented Nov 24, 2025

  • Ready only mode is a cli or env option
  • Both exist in local and lambda mode
  • Just checks env flag on execute
  • Only allows:
    • Select (should allow union)
    • Use
    • Should allow With (cte)
    • Explain should work only on the statements above
  • Added a service read only mode test
  • Manual testing:
    • Local
    • Lambda

Comment thread crates/executor/src/query.rs
Comment thread crates/executor/src/query.rs Outdated
@DanCodedThis
Copy link
Copy Markdown
Contributor Author

@rampage644 @osipovartem @Vedin

  • Should we allow transaction statements (commit, rollback) that are not doing anything in read only mode?
  • Or any statements which we support but not produce anything?
  • Basically, what other statements should we have?

@DanCodedThis DanCodedThis merged commit 491d9ac into main Nov 24, 2025
3 checks passed
@DanCodedThis DanCodedThis deleted the DanCodedThis/read-only-mode branch November 24, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants