Skip to content

fix: Sessions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanCodedThis merged 2 commits into from
Nov 13, 2025
Merged

fix: Sessions #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ee5c4
fix sessions
DanCodedThis Nov 13, 2025
4c27794
fix sessions fmt
DanCodedThis Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/embucketd/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ license-file.workspace = true
executor = { path = "../executor" }
catalog-metastore = { path = "../catalog-metastore" }
api-snowflake-rest = { path = "../api-snowflake-rest" }
api-snowflake-rest-sessions = { path = "../api-snowflake-rest-sessions" }
axum = { workspace = true }
clap = { workspace = true }
console-subscriber = { version = "0.4.1" }
Expand Down
17 changes: 15 additions & 2 deletions crates/embucketd/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ pub(crate) mod helpers;
pub(crate) mod layers;
pub(crate) mod metastore_config;

use crate::metastore_config::MetastoreBootstrapConfig;
use api_snowflake_rest::server::layer::require_auth as snowflake_require_auth;
use api_snowflake_rest::server::router::create_auth_router as create_snowflake_auth_router;
use api_snowflake_rest::server::router::create_router as create_snowflake_router;
use api_snowflake_rest::server::server_models::Config;
use api_snowflake_rest::server::state::AppState as SnowflakeAppState;
use api_snowflake_rest_sessions::session::{SESSION_EXPIRATION_SECONDS, SessionStore};
use axum::middleware;
use axum::{
Json, Router,
Expand Down Expand Up @@ -41,8 +43,6 @@ use tracing_subscriber::fmt::format::FmtSpan;
use tracing_subscriber::{Layer, layer::SubscriberExt, util::SubscriberInitExt};
use utoipa::OpenApi;
use utoipa_swagger_ui::SwaggerUi;

use crate::metastore_config::MetastoreBootstrapConfig;
// use core_sqlite::SqliteDb;

#[cfg(feature = "alloc-tracing")]
Expand Down Expand Up @@ -166,6 +166,19 @@ async fn async_main(
);
tracing::info!("Execution service created");

let session_store = SessionStore::new(execution_svc.clone());

tokio::task::spawn({
let session_store = session_store.clone();
async move {
session_store
.continuously_delete_expired(tokio::time::Duration::from_secs(
SESSION_EXPIRATION_SECONDS,
))
.await;
}
});

let snowflake_state = SnowflakeAppState {
execution_svc: execution_svc.clone(),
config: snowflake_rest_cfg,
Expand Down