ci(ios): Parallelize snapshot workflow across simulator matrix

Split the Sentry snapshots workflow into three stages: a single
build-for-testing job that archives the test products, a matrix job
that runs the snapshot tests on each simulator in parallel, and a
final aggregation job that downloads every per-sim artifact and
uploads them to Sentry in one fastlane invocation.

Rename the workflows to "Sentry Snapshots Upload" so the renamed
naming is consistent between the sequential and Swift Snapshot
Testing variants.

Author: cameroncooke

.github/workflows/ios_sentry_upload_snapshots.yml

@@ -1,4 +1,4 @@
-name: Sentry iOS Upload (Snapshots)
+name: Sentry Snapshots Upload
 
 on:
   push:
@@ -15,9 +15,12 @@ defaults:
 env:
   DERIVED_DATA_PATH: ${{ github.workspace }}/DerivedData-snapshot-upload
   SNAPSHOT_UPLOAD_BASE_DIR: ${{ github.workspace }}/ios/snapshot-images
+  BUILD_PRODUCTS_ARCHIVE: ${{ github.workspace }}/snapshot-build-products.tar.gz
 
 jobs:
-  upload_sentry_snapshots:
+  # Build the snapshot test bundle once on a single runner, then share the
+  # products with downstream simulator jobs via an artifact.
+  build_for_testing:
     runs-on: macos-26
 
     env:
@@ -41,6 +44,9 @@ jobs:
       - name: Setup gems
         run: exec ../.github/scripts/ios/setup.sh
 
+      - name: Prepare DerivedData directory
+        run: mkdir -p "${DERIVED_DATA_PATH}"
+
       - name: Cache Swift Package Manager
         uses: actions/cache@v4
         with:
@@ -50,20 +56,7 @@ jobs:
           key: ${{ runner.os }}-spm-${{ hashFiles('**/Package.resolved') }}
           restore-keys: ${{ runner.os }}-spm-
 
-      - name: Prepare snapshot directories
-        run: |
-          mkdir -p "${SNAPSHOT_UPLOAD_BASE_DIR}/iphone-17-pro-max"
-          mkdir -p "${SNAPSHOT_UPLOAD_BASE_DIR}/iphone-17e"
-          mkdir -p "${SNAPSHOT_UPLOAD_BASE_DIR}/ipad-air-11-inch-m4"
-          mkdir -p "${DERIVED_DATA_PATH}"
-
-      - name: Boot simulators
-        run: |
-          xcrun simctl boot "iPhone 17 Pro Max" || true
-          xcrun simctl boot "iPhone 17e" || true
-          xcrun simctl boot "iPad Air 11-inch (M4)" || true
-
-      - name: Build snapshot tests
+      - name: Build snapshot tests for distribution
         run: |
           set -o pipefail && xcodebuild build-for-testing \
             -scheme HackerNews \
@@ -82,6 +75,77 @@ jobs:
             FUSE_BUILD_SCRIPT_PHASES=YES \
             | xcpretty
 
+      - name: Archive test products
+        run: tar -C "${DERIVED_DATA_PATH}/Build" -czf "${BUILD_PRODUCTS_ARCHIVE}" Products
+
+      - name: Upload build products artifact
+        uses: actions/upload-artifact@v7
+        with:
+          name: snapshot-build-products
+          path: ${{ env.BUILD_PRODUCTS_ARCHIVE }}
+          if-no-files-found: error
+
+  # One simulator per runner. Each job extracts the shared build products,
+  # runs the snapshot tests, and uploads its PNGs as a per-sim artifact so
+  # the final job can aggregate them.
+  generate_snapshots:
+    runs-on: macos-26
+    needs: build_for_testing
+
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - simulator_name: iPhone 17 Pro Max
+            slug: iphone-17-pro-max
+          - simulator_name: iPhone 17e
+            slug: iphone-17e
+          - simulator_name: iPad Air 11-inch (M4)
+            slug: ipad-air-11-inch-m4
+
+    env:
+      XCODE_RUNNING_FOR_PREVIEWS: 1
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+
+      - name: Select Xcode 26.4
+        run: sudo xcode-select -s /Applications/Xcode_26.4.app
+
+      - name: Set up Ruby env
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.3.10
+          bundler-cache: true
+
+      - name: Setup gems
+        run: exec ../.github/scripts/ios/setup.sh
+
+      - name: Download build products artifact
+        uses: actions/download-artifact@v5
+        with:
+          name: snapshot-build-products
+          path: ${{ github.workspace }}
+
+      - name: Extract test products
+        # Restore the build products back under the same DerivedData path used
+        # during build-for-testing. The generated .xctestrun file references
+        # those product locations directly, so test-without-building does not
+        # need an extra -derivedDataPath flag as long as we recreate the same
+        # layout on each runner.
+        run: |
+          mkdir -p "${DERIVED_DATA_PATH}/Build"
+          tar -C "${DERIVED_DATA_PATH}/Build" -xzf "${BUILD_PRODUCTS_ARCHIVE}"
+
+      - name: Set snapshot export directory
+        # Xcode strips the TEST_RUNNER_ prefix and forwards the rest into the
+        # test runner process, which is how the snapshot tests discover where
+        # to write PNGs.
+        run: echo "TEST_RUNNER_SNAPSHOTS_EXPORT_DIR=${SNAPSHOT_UPLOAD_BASE_DIR}/${{ matrix.slug }}" >> "$GITHUB_ENV"
+
       - name: Resolve xctestrun file
         run: |
           XCTESTRUN_PATH="$(find "${DERIVED_DATA_PATH}/Build/Products" -name '*.xctestrun' -print -quit)"
@@ -91,40 +155,63 @@ jobs:
           fi
           echo "XCTESTRUN_PATH=${XCTESTRUN_PATH}" >> "$GITHUB_ENV"
 
-      - name: Generate snapshot images (iPhone 17 Pro Max)
-        env:
-          TEST_RUNNER_SNAPSHOTS_EXPORT_DIR: ${{ env.SNAPSHOT_UPLOAD_BASE_DIR }}/iphone-17-pro-max
-        run: |
-          set -o pipefail && xcodebuild test-without-building \
-            -xctestrun "${XCTESTRUN_PATH}" \
-            -destination 'platform=iOS Simulator,name=iPhone 17 Pro Max,arch=arm64' \
-            -only-testing:HackerNewsTests/HackerNewsSnapshotTest \
-            -resultBundlePath ../SnapshotResults-iphone-17-pro-max.xcresult \
-            | xcpretty
+      - name: Boot simulator
+        run: xcrun simctl boot "${{ matrix.simulator_name }}" || true
 
-      - name: Generate snapshot images (iPhone 17e)
-        env:
-          TEST_RUNNER_SNAPSHOTS_EXPORT_DIR: ${{ env.SNAPSHOT_UPLOAD_BASE_DIR }}/iphone-17e
-        run: |
-          set -o pipefail && xcodebuild test-without-building \
-            -xctestrun "${XCTESTRUN_PATH}" \
-            -destination 'platform=iOS Simulator,name=iPhone 17e,arch=arm64' \
-            -only-testing:HackerNewsTests/HackerNewsSnapshotTest \
-            -resultBundlePath ../SnapshotResults-iphone-17e.xcresult \
-            | xcpretty
+      - name: Prepare snapshot export directory
+        run: mkdir -p "${TEST_RUNNER_SNAPSHOTS_EXPORT_DIR}"
 
-      - name: Generate snapshot images (iPad)
-        env:
-          TEST_RUNNER_SNAPSHOTS_EXPORT_DIR: ${{ env.SNAPSHOT_UPLOAD_BASE_DIR }}/ipad-air-11-inch-m4
+      - name: Generate snapshot images
         run: |
           set -o pipefail && xcodebuild test-without-building \
             -xctestrun "${XCTESTRUN_PATH}" \
-            -destination 'platform=iOS Simulator,name=iPad Air 11-inch (M4),arch=arm64' \
+            -destination 'platform=iOS Simulator,name=${{ matrix.simulator_name }},arch=arm64' \
             -only-testing:HackerNewsTests/HackerNewsSnapshotTest \
-            -resultBundlePath ../SnapshotResults-ipad-air-11-inch-m4.xcresult \
+            -resultBundlePath "../SnapshotResults-${{ matrix.slug }}.xcresult" \
             | xcpretty
 
       - name: List generated snapshot files
+        run: |
+          echo "Generated snapshot files for ${{ matrix.simulator_name }}:"
+          find "${TEST_RUNNER_SNAPSHOTS_EXPORT_DIR}" -type f | sort
+          echo
+          echo "Total PNG images: $(find "${TEST_RUNNER_SNAPSHOTS_EXPORT_DIR}" -type f -name '*.png' | wc -l | tr -d ' ')"
+
+      - name: Upload generated snapshots
+        uses: actions/upload-artifact@v7
+        with:
+          name: ${{ matrix.slug }}
+          path: ${{ env.TEST_RUNNER_SNAPSHOTS_EXPORT_DIR }}
+          if-no-files-found: error
+
+  # Aggregate every per-sim artifact and upload the combined set to Sentry
+  # in a single fastlane invocation.
+  upload_snapshots:
+    runs-on: macos-26
+    needs: generate_snapshots
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+
+      - name: Set up Ruby env
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.3.10
+          bundler-cache: true
+
+      - name: Setup gems
+        run: exec ../.github/scripts/ios/setup.sh
+
+      - name: Download generated snapshots
+        uses: actions/download-artifact@v5
+        with:
+          path: ${{ env.SNAPSHOT_UPLOAD_BASE_DIR }}
+          pattern: "*"
+
+      - name: List aggregated snapshot files
         run: |
           echo "Generated snapshot files:"
           find "${SNAPSHOT_UPLOAD_BASE_DIR}" -type f | sort

.github/workflows/ios_sentry_upload_swift_snapshots.yml

@@ -1,4 +1,4 @@
-name: Sentry iOS Upload (Swift Snapshot Testing)
+name: Sentry Snapshots Upload (Swift Snapshot Testing)
 
 on:
   push: