fix: max instruction was dupplicated but skipped

Author: EmixamPP

sources/camera/camerainstruction.cpp

@@ -91,22 +91,25 @@ CameraInstruction::CameraInstruction(uint8_t unit, uint8_t selector, const vecto
  * false if the maximum control has already been set
  */
 bool CameraInstruction::next() noexcept
-{
+{   
+    if (curCtrl == maxCtrl)
+        return false;
+        
     for (unsigned i = 0; i < curCtrl.size(); ++i)
     {
         uint16_t nextCtrli = static_cast<uint16_t>(curCtrl[i] + 1);
         if (nextCtrli > maxCtrl[i])
             curCtrl[i] = minCtrl[i]; // simulate "overflow"
-        else 
+        else
         {
             curCtrl[i] = static_cast<uint8_t>(nextCtrli);
             logDebugCtrl("new current:", curCtrl);
             return true;
-        }   
+        }
     }
 
+    // all are in overflow (should never arrive!)
     setMaxAsCur();
-
     return false;
 }
 

sources/driver/finder.cpp

@@ -119,29 +119,22 @@ unique_ptr<vector<unique_ptr<Driver>>> Finder::find()
             {
                 CameraInstruction instruction(camera, unit, selector);
                 const CameraInstruction initInstruction = instruction; // copy for reset later
-
-                if (!instruction.setMinAsCur()) // if no min instruction exists
-                    if (!instruction.next())    // start from the next one
-                        continue;               // if no next, skip
-
+                
+                instruction.setMinAsCur();
                 unsigned negAnswerCounter = 0;
-                do
-                {
+                while (negAnswerCounter < negAnswerLimit && instruction.next())
+                {   
+                    if (negAnswerCounter == negAnswerLimit - 1)
+                        instruction.setMaxAsCur();
+
                     if (camera.apply(instruction) && camera.isEmitterWorking())
                     {
                         drivers->push_back(createDriverFromInstruction(instruction, unit, selector));
                         if (drivers->size() == emitters) // all emitters are configured
                             return drivers;
                     }
                     ++negAnswerCounter;
-                    
-                    if (negAnswerCounter == negAnswerLimit - 1)
-                    {
-                        instruction.setMaxAsCur();
-                        continue;
-                    }
-
-                } while (negAnswerCounter < negAnswerLimit && instruction.next());
+                }
 
                 camera.apply(initInstruction);
                 Logger::debug("");