Skip to content

perf: eliminate N+1 auth query + chore: ESLint flat config migration #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmiyaKiritsugu3 merged 3 commits into from
Jun 1, 2026
Merged

perf: eliminate N+1 auth query + chore: ESLint flat config migration #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41da790
chore: migrate ESLint to flat config nativo, sweep dependabot, update…
EmiyaKiritsugu3 May 30, 2026
2995037
perf: eliminate N+1 auth query in batch treino save using getAuthRole…
EmiyaKiritsugu3 May 30, 2026
cdc58dc
fix: type error in $transaction mock - cast arg to callable
EmiyaKiritsugu3 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,54 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.3.1] — 2026-05-29 — ESLint FlatCompat Migration

### Fixed

- **eslint-config-next v16 + FlatCompat circular JSON**: Migrated `eslint.config.mjs` from `FlatCompat` bridge (`compat.extends('next/core-web-vitals')`) to native flat config import (`import nextCoreWebVitals from 'eslint-config-next/core-web-vitals'`). Resolves `TypeError: Converting circular structure to JSON` that broke local `npm run lint`.
- **Removed `@eslint/eslintrc`**: No longer needed after FlatCompat removal — eliminates 1 direct devDependency and 4 transitive packages.
- **Removed `@eslint/config-array` and `@types/eslint`**: Unused direct devDependencies after migration; eslint provides its own transitive copies.
- **eslint-config-prettier**: Switched from default to `/flat` subpath import for proper flat config `name` field.
- **eslint-config-next semver range**: Updated `package.json` from `^15.5.15` to `^16.2.6` to match installed version.

### Changed

- **New React Compiler rules**: `react-hooks/set-state-in-effect` and `react-hooks/incompatible-library` (new in eslint-config-next v16) downgraded from `error` to `warn` — they flag legitimate patterns in shadcn/ui generated code and localStorage hydration. TODO: fix patterns and promote to `error`.

## [1.3.0] — 2026-05-29 — Dependabot Sweep & CI Optimization

### Added

- **SonarCloud Coverage Integration**: Configured `sonar.javascript.lcov.reportPaths=coverage/lcov.info` in `sonar-project.properties`; `sonarqube-scan-action` now uploads coverage data automatically after `npm run test:coverage` in CI.
- **CI Badge**: Added GitHub Actions workflow status badge and SonarCloud quality gate badge to `README.md`.
- **Quality Gates Documentation**: Updated `README.md` with current test counts (66 vitest, 20 E2E scenarios) and CI pipeline description.

### Changed

- **CI Optimization** (PR #110): `.github/workflows/ci.yml` now skips `lint`, `format:check`, `typecheck`, `test` (vitest + SonarCloud), and `e2e` (Playwright) jobs for Dependabot PRs using `if: github.event.pull_request.user.login != 'dependabot[bot]'`. Dependabot PRs only run `npm ci` + `npm audit` (~2min vs ~15min).
- **CI Trigger Filter**: Added `paths-ignore` for `docs/**`, `*.md`, `.gitignore`, `LICENSE`, `.prettierignore`, `.eslintrc*` to skip CI for documentation-only changes.
- **Node.js Version in Docs**: Updated from `20+` to `>=22.0.0` to match `package.json` engine constraint.

### Fixed

- **GitGuardian False Positives on Dependabot PRs**: Native GitHub App scans ALL commits in PR history. Fixed by force-pushing squashed commits (single commit per Dependabot branch) on PRs #102, #104, #105.
- **Dependabot Lockfile Drift**: Lockfiles generated by Dependabot were based on outdated `main`, causing `npm ci` failures. Fix: checkout latest `main`, run `npm install <pkg>@<version>`, commit only `package.json` + `package-lock.json`.

### Merged Dependencies

- `@types/node` 20.17.10 → 25.0.8 (#101)
- `lucide-react` 0.475.0 → 1.16.0 (#102)
- `react-day-picker` 10.0.0 → 10.0.1 (#103)
- `tailwind-merge` 2.6.1 → 3.6.0 (#104)
- `eslint-config-next` 15.5.15 → 16.2.6 (#105)
- `qs` 6.15.1 → 6.15.2 (#107)

### Known Issues

- **react-hooks/set-state-in-effect**: New eslint-config-next v16 rule flags `setState` calls inside `useEffect` (6 occurrences in our code + shadcn/ui components). Downgraded to `warn` pending refactoring to `useSyncExternalStore` or initializer patterns.

---

## [1.2.0] — 2026-05-14 — Security Hardening & Audit Pipeline Fix

### Added
Expand Down
18 changes: 13 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
[![Supabase](https://img.shields.io/badge/Supabase-Database-green?style=for-the-badge&logo=supabase)](https://supabase.com/)
[![Prisma](https://img.shields.io/badge/Prisma-ORM-2D3748?style=for-the-badge&logo=prisma)](https://www.prisma.io/)
[![Genkit](https://img.shields.io/badge/Genkit-AI-orange?style=for-the-badge&logo=googlecloud)](https://firebase.google.com/docs/genkit)
[![SonarCloud](https://img.shields.io/badge/SonarCloud-Quality_Gate-blue?style=for-the-badge&logo=sonarcloud)](https://sonarcloud.io/project/overview?id=EmiyaKiritsugu3_PWeb_Project)
[![CI](https://img.shields.io/github/actions/workflow/status/EmiyaKiritsugu3/PWeb_Project/ci.yml?branch=main&style=for-the-badge&logo=github)](https://github.com/EmiyaKiritsugu3/PWeb_Project/actions)

Um sistema de gestão **full-stack** moderno para academias, combinando ferramentas administrativas robustas com uma experiência de aluno gamificada e potencializada por **Inteligência Artificial Generativa**.

Expand Down Expand Up @@ -75,7 +77,7 @@ O projeto inclui o **Sentinel**, um sistema operacional de desenvolvimento alime

### Pré-requisitos

- Node.js 20+
- Node.js 22+
- Docker (necessário para o stack E2E local via Supabase CLI)
- npm

Expand Down Expand Up @@ -130,12 +132,18 @@ Acesse `http://localhost:3001` para ver a aplicação em execução.
### 4. Quality Gates

```bash
npm run typecheck # TypeScript strict — 0 erros
npm run lint # ESLint — 0 erros
npm run test # Vitest — 18/18 testes
npm run e2e # Playwright — 15/15 cenários (requer Docker + supabase start)
npm run typecheck # TypeScript strict — 0 erros
npm run lint # ESLint — 0 erros (Native flat config + ESLint 9)
npm run format:check # Prettier — formatação consistente
npm run test # Vitest — 66/66 testes (10 suites)
npm run e2e # Playwright — 20 cenários (requer Docker + supabase start)
npm run test:coverage # Testes + relatório de cobertura (enviado ao SonarCloud)
```

> **Integração Contínua:** O pipeline CI ([`.github/workflows/ci.yml`](./.github/workflows/ci.yml)) executa todos os quality gates em cada PR.
> Para PRs do **Dependabot**, testes e E2E são pulados para agilizar — apenas `npm ci` + `npm audit` rodam.
> **SonarCloud** analisa cobertura automaticamente via `sonarqube-scan-action` com `coverage/lcov.info`.

---

## 📘 Documentação do Projeto
Expand Down
25 changes: 24 additions & 1 deletion docs/CURRENT-STATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,24 @@
Estado atual: Sistema estabilizado, PR #90 mergado com sucesso. Arquitetura ADF v1.2 em vigor.
# Estado Atual (2026-05-29)

## Estabilizado — ESLint FlatCompat Migration + Dependabot Sweep + CI Otimizado

**Última versão:** 1.3.1
**Branch principal:** `main`
**CI:** Pipeline otimizado — Dependabot PRs pulam testes/E2E; PRs regulares rodam quality gates completos. Lint local funcional.

### O que foi feito

- **ESLint FlatCompat Migration**: `eslint.config.mjs` migrado de `FlatCompat` para flat config nativo do `eslint-config-next` v16. Resolvido `TypeError: Converting circular structure to JSON`. Removidos `@eslint/eslintrc`, `@eslint/config-array`, `@types/eslint` das devDependencies.
- **Dependabot Sweep:** Todos os 6 PRs de dependências (#101 a #107) mergeados com sucesso, incluindo:
- `@types/node` 20→25
- `lucide-react` 0.475→1.16
- `react-day-picker` patch
- `tailwind-merge` 2→3
- `eslint-config-next` 15→16
- `qs` patch
- **CI Otimizado** (PR #110): Testes vitest e E2E pulados para Dependabot; `paths-ignore` para docs-only.
- **Cobertura SonarCloud**: Configurado `sonar.javascript.lcov.reportPaths` para upload de cobertura via `sonarqube-scan-action`.

### Pendências Técnicas

- **react-hooks/set-state-in-effect**: Regra nova do eslint-config-next v16 sinaliza `setState` dentro de `useEffect` (6 ocorrências). Downgradado para `warn`. Refatorar para `useSyncExternalStore` ou padrões de initializer quando conveniente.
20 changes: 7 additions & 13 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,15 @@
import js from '@eslint/js';
import tseslint from 'typescript-eslint';
import prettierConfig from 'eslint-config-prettier';
import { FlatCompat } from '@eslint/eslintrc';
import path from 'path';
import { fileURLToPath } from 'url';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

const compat = new FlatCompat({
baseDirectory: __dirname,
});
import prettierConfig from 'eslint-config-prettier/flat';

@coderabbitai coderabbitai Bot May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

prettierConfig is imported but never added to the config — Prettier integration is lost.

eslint-config-prettier/flat is imported but is not included in the tseslint.config(...) argument list, so the rules that disable ESLint formatting checks conflicting with Prettier are no longer applied. This both triggers the @typescript-eslint/no-unused-vars error flagged by static analysis and silently regresses the Prettier/ESLint integration. Add it as the last entry so it overrides earlier formatting rules.

🔧 Proposed fix to re-apply the flat Prettier config 
   ...nextCoreWebVitals,
   {
     files: ['**/*.ts', '**/*.tsx'],
@@
     rules: {
@@
       'prefer-const': 'error',
     },
   },
+  prettierConfig,
 );
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
import prettierConfig from 'eslint-config-prettier/flat';
...nextCoreWebVitals,
{
files: ['**/*.ts', '**/*.tsx'],
rules: {
'prefer-const': 'error',
},
},
prettierConfig,
);
🧰 Tools
🪛 ESLint

[error] 3-3: 'prettierConfig' is defined but never used.

(@typescript-eslint/no-unused-vars)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@eslint.config.mjs` at line 3, Import prettierConfig is unused because it
wasn't appended to the ESLint config; add prettierConfig as the last entry in
the array passed to the ts(eslint?) config function (refer to the call where you
build the config, e.g., tse eslint.config(...) or similar) so the Prettier flat
rules override earlier formatting rules and remove the unused-import error;
ensure prettierConfig is the final element in the extends/plugins/rules merging
point used to export the config.

@cubic-dev-ai cubic-dev-ai Bot May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: prettierConfig is imported but never included in the tseslint.config(...) array. This means ESLint rules that conflict with Prettier are no longer disabled, silently regressing Prettier integration. Add prettierConfig as the last entry in the config array (after the custom rules block).

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At eslint.config.mjs, line 3:

<comment>`prettierConfig` is imported but never included in the `tseslint.config(...)` array. This means ESLint rules that conflict with Prettier are no longer disabled, silently regressing Prettier integration. Add `prettierConfig` as the last entry in the config array (after the custom rules block).</comment>

<file context>
@@ -1,25 +1,15 @@
-const compat = new FlatCompat({
-  baseDirectory: __dirname,
-});
+import prettierConfig from 'eslint-config-prettier/flat';
+import nextCoreWebVitals from 'eslint-config-next/core-web-vitals';
 
</file context>

import nextCoreWebVitals from 'eslint-config-next/core-web-vitals';

export default tseslint.config(
{
ignores: ['.next/**', 'node_modules/**', 'coverage/**', 'src/components/ui/sidebar.tsx'],
},
js.configs.recommended,
...tseslint.configs.recommended,
...compat.extends('next/core-web-vitals'),
prettierConfig,
...nextCoreWebVitals,
{
files: ['**/*.ts', '**/*.tsx'],
languageOptions: {
Expand All @@ -35,6 +25,10 @@ export default tseslint.config(
{ argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' },
],
'@typescript-eslint/consistent-type-imports': ['warn', { prefer: 'type-imports' }],
// Downgrade new eslint-config-next v16 React Compiler rules to warnings
// TODO: Fix patterns and promote to 'error' once shadcn/ui components are updated
'react-hooks/set-state-in-effect': 'warn',
'react-hooks/incompatible-library': 'warn',
'no-console': 'warn',
'no-debugger': 'error',
'prefer-const': 'error',
Expand Down
Loading
Loading