Skip to content

fix: 15 code quality issues — generics, types, locale, dead code, naming #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmiyaKiritsugu3 merged 34 commits into from
Jun 4, 2026
Merged

fix: 15 code quality issues — generics, types, locale, dead code, naming #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
1ba2119
feat: add getErrorMessage utility for safe error extraction
EmiyaKiritsugu3 Jun 3, 2026
f650f27
refactor: remove unnecessary type assertions in alunoService.ts
EmiyaKiritsugu3 Jun 3, 2026
d544dff
refactor: use getErrorMessage in treinos.ts error handlers
EmiyaKiritsugu3 Jun 3, 2026
a394ed6
refactor: simplify type assertions in logger.ts
EmiyaKiritsugu3 Jun 3, 2026
0f5adc2
chore: remove redundant dotenv config in Next.js context
EmiyaKiritsugu3 Jun 3, 2026
1e4787f
refactor: add runtime validation for localStorage language cast
EmiyaKiritsugu3 Jun 3, 2026
74d0b82
refactor: remove redundant type assertions in workout-generator-flow.ts
EmiyaKiritsugu3 Jun 3, 2026
c06cf77
chore: enable noUnusedLocals and noUnusedParameters
EmiyaKiritsugu3 Jun 3, 2026
e602f96
refactor: use getErrorMessage in planos.ts and meus-treinos-client.tsx
EmiyaKiritsugu3 Jun 3, 2026
847c558
chore: remove unused exports from service files
EmiyaKiritsugu3 Jun 3, 2026
0347bef
refactor: remove unsafe type assertions in treinos-client.tsx
EmiyaKiritsugu3 Jun 3, 2026
012a8be
refactor: replace magic numbers with named constants
EmiyaKiritsugu3 Jun 3, 2026
ce0ecf0
refactor: extract getZodError helper, remove duplicate cast in planos.ts
EmiyaKiritsugu3 Jun 3, 2026
36b7471
refactor: extract shared handleActionError to eliminate DRY violations
EmiyaKiritsugu3 Jun 3, 2026
bcedab4
fix(db): add generic type params to dummyDb methods
EmiyaKiritsugu3 Jun 4, 2026
ebd8742
fix(components): add type params to row.getValue() calls
EmiyaKiritsugu3 Jun 4, 2026
aef678b
fix(ai): type-narrow Genkit streaming output via schema
EmiyaKiritsugu3 Jun 4, 2026
cc5fb23
fix(i18n): map legacy 'pt-BR' locale to 'pt' language
EmiyaKiritsugu3 Jun 4, 2026
469662e
fix(utils): add optional customMessage param to handleActionError
EmiyaKiritsugu3 Jun 4, 2026
2c6f47a
fix(utils): replace unsafe type casts in logger with safe helper
EmiyaKiritsugu3 Jun 4, 2026
19bbde3
chore: remove empty placeholder-images.ts and orphan .json
EmiyaKiritsugu3 Jun 4, 2026
5665d59
refactor(data): rename misleading growth projection constants
EmiyaKiritsugu3 Jun 4, 2026
820a193
docs: update changelog and current-state for v1.4.0 (PR #118)
EmiyaKiritsugu3 Jun 4, 2026
6bfcbd5
fix(error): extend handleActionError with zodMessage/fallbackMessage …
EmiyaKiritsugu3 Jun 4, 2026
a586b6c
fix(ai): safeParse validation before sendChunk + null guard in genera…
EmiyaKiritsugu3 Jun 4, 2026
a0dcfb3
refactor(treinos): migrate registrarHistoricoTreinoAction to handleAc…
EmiyaKiritsugu3 Jun 4, 2026
bcda9b6
test(treinos,ai): regression tests for NaN/parseInt guards and Zod er…
EmiyaKiritsugu3 Jun 4, 2026
4d1a43d
fix(treinos): revert repeticoes to nullish coalescing for type safety
EmiyaKiritsugu3 Jun 4, 2026
2f847cc
fix(actions): add ActionResult<T> discriminated union for alunos serv…
EmiyaKiritsugu3 Jun 4, 2026
b192d9b
fix(deps): remove typosquatted 'supabase' malware package
EmiyaKiritsugu3 Jun 4, 2026
6f709bc
fix(actions): drop broken HistoricoTreinoSchema.parse() + dummyDb | n…
EmiyaKiritsugu3 Jun 4, 2026
25beaa6
ci(sonar): upgrade sonarqube-scan-action to v6
EmiyaKiritsugu3 Jun 4, 2026
c69cb28
fix(e2e): wrap seed-e2e top-level await in main() for tsx CJS compat
EmiyaKiritsugu3 Jun 4, 2026
5498f4f
ci(sonar): revert action upgrade (caused JRE download 403)
EmiyaKiritsugu3 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .sisyphus/boulder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"active_plan": "/home/emiyakiritsugu/Projetos_Antigravity/PWeb_Project/.sisyphus/plans/pr118-correction-optimization.md",

@cubic-dev-ai cubic-dev-ai Bot Jun 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: active_plan uses a hardcoded absolute path tied to the local development machine (/home/emiyakiritsugu/...). This path will not resolve on any other developer's machine or CI environment, making this configuration file non-portable and effectively broken outside the original machine. The target file already exists at .sisyphus/plans/pr118-correction-optimization.md relative to the repo root, so a relative path can be used instead.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .sisyphus/boulder.json, line 2:

<comment>`active_plan` uses a hardcoded absolute path tied to the local development machine (`/home/emiyakiritsugu/...`). This path will not resolve on any other developer's machine or CI environment, making this configuration file non-portable and effectively broken outside the original machine. The target file already exists at `.sisyphus/plans/pr118-correction-optimization.md` relative to the repo root, so a relative path can be used instead.</comment>

<file context>
@@ -0,0 +1,22 @@
+{
+  "active_plan": "/home/emiyakiritsugu/Projetos_Antigravity/PWeb_Project/.sisyphus/plans/pr118-correction-optimization.md",
+  "started_at": "2026-06-04T01:25:46.597Z",
+  "session_ids": [
</file context>

"started_at": "2026-06-04T01:25:46.597Z",
"session_ids": [
"ses_1776758b8ffe0IKUMawLYpvPQw",
"ses_16fc27358ffeNfun8Qdh7fDluf",
"ses_16fc259c1ffeUtNcUJmLcWbkvA",
"ses_16fc23e3dffeJ6WOz1M0iDykXL",
"ses_16fc225bcffe8abQwLq23BbDq2",
"ses_16fa87119ffe70sEei10acP95M",
"ses_16fa2e3f1ffe8viXu177SRNzjC",
"ses_16fa213a6ffeMyoy60MLCpUBRz",
"ses_16fa173bfffeerYy4m153uWUfJ",
"ses_16fa10d14ffe4dXS00EPOklz5M",
"ses_16fa09c45ffe6T4ncs74X2Hm0y",
"ses_16fa008ebffeHZQKKVydt0uUhc",
"ses_16f9f8481ffenZzCAX6sheyvdu"
],
"plan_name": "pr118-correction-optimization",
"agent": "atlas",
"task_sessions": {}
}
8 changes: 8 additions & 0 deletions .sisyphus/evidence/wave0-baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
> vitest run
RUN v4.1.6 /home/emiyakiritsugu/Projetos_Antigravity/PWeb_Project
Test Files 10 passed (10)
Tests 71 passed (71)
Start at 22:26:33
Duration 1.27s (transform 812ms, setup 698ms, import 1.40s, tests 212ms, environment 7.15s)
(node:165263) [DEP0205] DeprecationWarning: `module.register()` is deprecated. Use `module.registerHooks()` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
3 changes: 3 additions & 0 deletions .sisyphus/evidence/wave0-constants.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
src/lib/data.ts:124: const STREAK_MULTIPLIER = 0.7;
src/lib/data.ts:125: const BONUS_THRESHOLD = 0.05;
src/lib/data.ts:129: alunos: Math.floor(totalAlunos * (STREAK_MULTIPLIER + idx * BONUS_THRESHOLD)),
Empty file added .sisyphus/evidence/wave0-imports.txt
View file
Open in desktop
Empty file.
Loading
Loading