-
Notifications
You must be signed in to change notification settings - Fork 0
feat(it5): INSTRUTOR authorization hardening (#007) #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
784069b
docs(it5): open It5-T01 branch — update CURRENT-STATE + CLAUDE.md
EmiyaKiritsugu3 5da5811
docs(it5): document pre-existing TS2882 regression in quality gates
EmiyaKiritsugu3 95ee4d6
fix(typecheck): restore src/types/css.d.ts deleted in PR #80 TS6 upgrade
EmiyaKiritsugu3 e12a927
docs(it5): mark TS2882 resolved in CURRENT-STATE quality gates
EmiyaKiritsugu3 f5a27a5
fix(it5): add requireAnyRole helper to auth.ts
EmiyaKiritsugu3 1746b75
fix(it5): add failing E2E negative auth test (TDD red)
EmiyaKiritsugu3 30e1742
fix(it5): gate /dashboard/treinos with requireAnyRole
EmiyaKiritsugu3 0dd8999
fix(it5): add failing unit tests for treinos actions (TDD red)
EmiyaKiritsugu3 2a1bb92
fix(it5): remove instrutorId from TreinoBaseSchema (server-derived)
EmiyaKiritsugu3 650febc
fix(it5): derive instrutorId from session in upsertTreinoAction
EmiyaKiritsugu3 751fcc7
fix(it5): remove instrutorId prop from TreinosManagementClient
EmiyaKiritsugu3 0ff04c6
fix(it5): remove redundant getUser and instrutorId prop from TreinosPage
EmiyaKiritsugu3 cca2b40
fix(it5): add ownership check to updateTreinoDayAction
EmiyaKiritsugu3 582f9e7
fix(it5): add ownership check to deleteTreinoAction
EmiyaKiritsugu3 40158d8
chore(it5): update CRITICAL-PATHS.md 18 → 19 scenarios
EmiyaKiritsugu3 8bff4a2
docs: update CURRENT-STATE.md for It5 completion
EmiyaKiritsugu3 7761e84
test(it5): add requireAnyRole unit tests to restore auth.ts 100% cove…
EmiyaKiritsugu3 b9035a3
fix(auth): address CodeRabbit review findings on PR #81
EmiyaKiritsugu3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CURRENT-STATE.mdis already out of sync with this PR.This file still reports 19 E2E scenarios and a pending
npm run e2e, while the PR status here says 20/20 scenarios are passing and the PR is ready. Please refresh the counts/status here as well, or this handoff doc stops being trustworthy. Based on learnings, "Maintain and updatedocs/CURRENT-STATE.mdat the start and end of every session to document progress and blockers".Also applies to: 23-29, 65-68
🤖 Prompt for AI Agents