[New] 重命名支持索引访问

Author: xuhuanzy

crates/emmylua_ls/src/handlers/rename/mod.rs

@@ -5,7 +5,7 @@ mod rename_type;
 use std::collections::HashMap;
 
 use emmylua_code_analysis::{LuaCompilation, LuaSemanticDeclId, SemanticDeclLevel, SemanticModel};
-use emmylua_parser::{LuaAstNode, LuaSyntaxToken, LuaTokenKind};
+use emmylua_parser::{LuaAstNode, LuaLiteralExpr, LuaSyntaxToken, LuaTableField, LuaTokenKind};
 use lsp_types::{
     ClientCapabilities, OneOf, PrepareRenameResponse, RenameOptions, RenameParams,
     ServerCapabilities, TextDocumentPositionParams, WorkspaceEdit,
@@ -29,37 +29,7 @@ pub async fn on_rename_handler(
     let analysis = context.analysis.read().await;
     let file_id = analysis.get_file_id(&uri)?;
     let position = params.text_document_position.position;
-    let mut semantic_model = analysis.compilation.get_semantic_model(file_id)?;
-    let root = semantic_model.get_root();
-    let position_offset = {
-        let document = semantic_model.get_document();
-        document.get_offset(position.line as usize, position.character as usize)?
-    };
-
-    if position_offset > root.syntax().text_range().end() {
-        return None;
-    }
-
-    let token = match root.syntax().token_at_offset(position_offset) {
-        TokenAtOffset::Single(token) => token,
-        TokenAtOffset::Between(left, right) => {
-            if left.kind() == LuaTokenKind::TkName.into() {
-                left
-            } else {
-                right
-            }
-        }
-        TokenAtOffset::None => {
-            return None;
-        }
-    };
-
-    rename_references(
-        &mut semantic_model,
-        &analysis.compilation,
-        token,
-        params.new_name,
-    )
+    rename(&analysis, file_id, position, params.new_name)
 }
 
 pub async fn on_prepare_rename_handler(
@@ -94,7 +64,6 @@ pub async fn on_prepare_rename_handler(
             return None;
         }
     };
-
     if matches!(
         token.kind().into(),
         LuaTokenKind::TkName | LuaTokenKind::TkInt | LuaTokenKind::TkString
@@ -107,14 +76,55 @@ pub async fn on_prepare_rename_handler(
     }
 }
 
+pub fn rename(
+    analysis: &emmylua_code_analysis::EmmyLuaAnalysis,
+    file_id: emmylua_code_analysis::FileId,
+    position: lsp_types::Position,
+    new_name: String,
+) -> Option<WorkspaceEdit> {
+    let mut semantic_model = analysis.compilation.get_semantic_model(file_id)?;
+    let root = semantic_model.get_root();
+    let position_offset = {
+        let document = semantic_model.get_document();
+        document.get_offset(position.line as usize, position.character as usize)?
+    };
+
+    if position_offset > root.syntax().text_range().end() {
+        return None;
+    }
+
+    let token = match root.syntax().token_at_offset(position_offset) {
+        TokenAtOffset::Single(token) => token,
+        TokenAtOffset::Between(left, right) => {
+            if left.kind() == LuaTokenKind::TkName.into() {
+                left
+            } else {
+                right
+            }
+        }
+        TokenAtOffset::None => {
+            return None;
+        }
+    };
+
+    rename_references(&mut semantic_model, &analysis.compilation, token, new_name)
+}
+
 fn rename_references(
     semantic_model: &SemanticModel,
     compilation: &LuaCompilation,
     token: LuaSyntaxToken,
     new_name: String,
 ) -> Option<WorkspaceEdit> {
     let mut result = HashMap::new();
-    let semantic_decl = semantic_model.find_decl(token.into(), SemanticDeclLevel::NoTrace)?;
+    let semantic_decl = match try_get_table_field(token.clone()) {
+        Some(table_field) => semantic_model.find_decl(
+            table_field.syntax().clone().into(),
+            SemanticDeclLevel::NoTrace,
+        ),
+        None => semantic_model.find_decl(token.into(), SemanticDeclLevel::NoTrace),
+    }?;
+
     match semantic_decl {
         LuaSemanticDeclId::LuaDecl(decl_id) => {
             rename_decl_references(semantic_model, compilation, decl_id, new_name, &mut result);
@@ -159,6 +169,12 @@ fn rename_references(
     })
 }
 
+fn try_get_table_field(token: LuaSyntaxToken) -> Option<LuaTableField> {
+    let parent = token.parent()?;
+    let literal_expr = LuaLiteralExpr::cast(parent)?;
+    literal_expr.get_parent::<LuaTableField>()
+}
+
 pub struct RenameCapabilities;
 
 impl RegisterCapabilities for RenameCapabilities {

crates/emmylua_ls/src/handlers/rename/rename_member.rs

@@ -3,7 +3,10 @@ use std::collections::HashMap;
 use emmylua_code_analysis::{
     LuaCompilation, LuaMemberId, LuaSemanticDeclId, SemanticDeclLevel, SemanticModel,
 };
-use emmylua_parser::{LuaAst, LuaAstNode, LuaAstToken, LuaNameToken, LuaSyntaxNode};
+use emmylua_parser::{
+    LuaAst, LuaAstNode, LuaAstToken, LuaIndexToken, LuaLiteralExpr, LuaNameToken, LuaSyntaxNode,
+    LuaTokenKind,
+};
 use lsp_types::Uri;
 
 use crate::handlers::hover::find_member_origin_owner;
@@ -44,11 +47,13 @@ pub fn rename_member_references(
             property_owner.clone(),
             SemanticDeclLevel::NoTrace,
         ) {
-            let range = get_member_name_token_lsp_range(semantic_model, node.clone())?;
-            result
-                .entry(semantic_model.get_document().get_uri())
-                .or_insert_with(HashMap::new)
-                .insert(range, new_name.clone());
+            let range = get_member_name_token_lsp_range(semantic_model, node.clone());
+            if let Some(range) = range {
+                result
+                    .entry(semantic_model.get_document().get_uri())
+                    .or_insert_with(HashMap::new)
+                    .insert(range, new_name.clone());
+            }
         }
     }
 
@@ -61,7 +66,20 @@ fn get_member_name_token_lsp_range(
 ) -> Option<lsp_types::Range> {
     let document = semantic_model.get_document();
     let node = LuaAst::cast(node)?;
-    // todo
-    let token = node.token::<LuaNameToken>()?;
-    document.to_lsp_range(token.get_range())
+    if let Some(token) = node.token::<LuaNameToken>() {
+        return document.to_lsp_range(token.get_range());
+    }
+
+    // 此时可能是 [] 访问
+    if let Some(_) = node.token::<LuaIndexToken>() {
+        let literal = node.child::<LuaLiteralExpr>()?.get_literal()?;
+        if matches!(
+            literal.get_token_kind(),
+            LuaTokenKind::TkInt | LuaTokenKind::TkString
+        ) {
+            return document.to_lsp_range(literal.get_range());
+        }
+    }
+
+    None
 }

crates/emmylua_ls/src/handlers/test/mod.rs

@@ -6,5 +6,6 @@ mod hover_function_test;
 mod hover_test;
 mod implementation_test;
 mod inlay_hint_test;
+mod rename_test;
 mod semantic_token_test;
 mod signature_helper_test;

crates/emmylua_ls/src/handlers/test/rename_test.rs

@@ -0,0 +1,21 @@
+#[cfg(test)]
+mod tests {
+    use crate::handlers::test_lib::ProviderVirtualWorkspace;
+
+    #[test]
+    fn test_int_key() {
+        let mut ws = ProviderVirtualWorkspace::new();
+        let result = ws.check_rename(
+            r#"
+                local export = {
+                    [<??>1] = 1,
+                }
+
+                export[1] = 2
+            "#,
+            "2".to_string(),
+            2,
+        );
+        assert!(result);
+    }
+}

crates/emmylua_ls/src/handlers/test_lib/mod.rs

@@ -350,4 +350,28 @@ impl ProviderVirtualWorkspace {
         dbg!(&data);
         Some(result)
     }
+
+    pub fn check_rename(&mut self, block_str: &str, new_name: String, len: usize) -> bool {
+        let content = Self::handle_file_content(block_str);
+        let Some((content, position)) = content else {
+            return false;
+        };
+        let file_id = self.def(&content);
+        let result = rename(&self.analysis, file_id, position, new_name.clone());
+        let Some(result) = result else {
+            return false;
+        };
+        // dbg!(&result);
+        if let Some(changes) = result.changes {
+            let mut count = 0;
+            for (_, edits) in changes {
+                count += edits.len();
+            }
+            if count != len {
+                return false;
+            }
+        }
+
+        true
+    }
 }