fix(diagnostic): prevent comments from shifting call argument diagnostics

fix #1158

Author: xuhuanzy

crates/emmylua_code_analysis/src/diagnostic/test/missing_fields_test.rs

@@ -1,5 +1,8 @@
 #[cfg(test)]
 mod tests {
+    use lsp_types::NumberOrString;
+    use tokio_util::sync::CancellationToken;
+
     use crate::{DiagnosticCode, VirtualWorkspace};
 
     #[test]
@@ -355,4 +358,50 @@ foo({})
         "#
         ));
     }
+
+    #[test]
+    fn test_call_argument_comment_does_not_shift_missing_fields_range() {
+        let mut ws = VirtualWorkspace::new();
+        ws.analysis
+            .diagnostic
+            .enable_only(DiagnosticCode::MissingFields);
+        let file_id = ws.def(
+            r#"---@class A
+---@field a 1
+---@class B
+---@field b 2
+---@class C
+---@field c 3
+
+---@param a A
+---@param b B
+---@param c C
+local function test(a, b, c) end
+
+test(
+    -- What
+    {},
+    {},
+    {}
+)"#,
+        );
+        let code = Some(NumberOrString::String(
+            DiagnosticCode::MissingFields.get_name().to_string(),
+        ));
+        let diagnostics = ws
+            .analysis
+            .diagnose_file(file_id, CancellationToken::new())
+            .unwrap_or_default()
+            .into_iter()
+            .filter(|diagnostic| diagnostic.code == code)
+            .collect::<Vec<_>>();
+
+        assert_eq!(diagnostics.len(), 3, "{diagnostics:#?}");
+        assert_eq!(diagnostics[0].range.start.line, 14, "{diagnostics:#?}");
+        assert!(diagnostics[0].message.contains("`a`"), "{diagnostics:#?}");
+        assert_eq!(diagnostics[1].range.start.line, 15, "{diagnostics:#?}");
+        assert!(diagnostics[1].message.contains("`b`"), "{diagnostics:#?}");
+        assert_eq!(diagnostics[2].range.start.line, 16, "{diagnostics:#?}");
+        assert!(diagnostics[2].message.contains("`c`"), "{diagnostics:#?}");
+    }
 }

crates/emmylua_code_analysis/src/semantic/infer/infer_table.rs

@@ -224,7 +224,7 @@ fn infer_table_type_by_callee(
     )?;
     let param_types = func_type.get_params();
     let mut call_arg_number = call_arg_list
-        .children::<LuaAst>()
+        .get_args()
         .enumerate()
         .find(|(_, arg)| arg.get_position() == table_expr.get_position())
         .ok_or(InferFailReason::None)?