Removes skip_table_fields_check LSP optimization

Author: xuhuanzy

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 *All notable changes to the EmmyLua Analyzer Rust project will be documented in this file.*
 
+## [Unreleased]
+
+### 🗑️ Removed
+
+- **`lsp_optimization`**: Removed the `skip_table_fields_check` optimization (including the old `check_table_field` alias). Table field diagnostics are no longer skipped via this attribute.
+
 ## [0.24.0] - 2026-7-10
 
 ### ✨ Added

crates/emmylua_code_analysis/resources/std/builtin.lua

@@ -181,11 +181,10 @@
 --- Language Server Optimization Items.
 ---
 --- Parameters:
---- - `skip_table_fields_check`: Skip table field diagnostics. It is recommended to use this option for all large configuration tables.
 --- - `delayed_definition`: Indicates that the type of the variable is determined by the first assignment.
 ---    Only valid for `local` declarations with no initial value.
 --- @class lsp_optimization: Attribute
---- @overload fun(code: "skip_table_fields_check"|"delayed_definition")
+--- @overload fun(code: "delayed_definition")
 
 ---
 --- Index field alias, will be displayed in `hint` and `completion`.

crates/emmylua_code_analysis/src/compilation/test/attribute_test.rs

@@ -34,19 +34,6 @@ mod test {
         assert_eq!(ws.humanize_type(ty), "A");
     }
 
-    #[test]
-    fn test_def_attribute() {
-        let mut ws = VirtualWorkspace::new_with_init_std_lib();
-
-        ws.has_no_diagnostic(
-            DiagnosticCode::AssignTypeMismatch,
-            r#"
-        ---@[lsp_optimization("skip_table_fields_check")]
-        local config = {}
-        "#,
-        );
-    }
-
     #[test]
     fn test_attribute_overload_uses_arg_type_for_diagnostic() {
         let mut ws = VirtualWorkspace::new();

crates/emmylua_code_analysis/src/db_index/property/builtin_attribute.rs

@@ -189,9 +189,6 @@ impl LuaAttributeUse {
         }
 
         let code = match self.get_string_param("code")? {
-            "skip_table_fields_check" | "check_table_field" => {
-                LuaLspOptimizationCode::SkipTableFieldsCheck
-            }
             "delayed_definition" => LuaLspOptimizationCode::DelayedDefinition,
             _ => return None,
         };
@@ -252,14 +249,12 @@ pub struct LuaDeprecatedAttribute<'a> {
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
 pub enum LuaLspOptimizationCode {
-    SkipTableFieldsCheck,
     DelayedDefinition,
 }
 
 impl LuaLspOptimizationCode {
     pub const fn as_str(self) -> &'static str {
         match self {
-            Self::SkipTableFieldsCheck => "skip_table_fields_check",
             Self::DelayedDefinition => "delayed_definition",
         }
     }
@@ -271,10 +266,6 @@ pub struct LuaLspOptimizationAttribute {
 }
 
 impl LuaLspOptimizationAttribute {
-    pub fn is_skip_table_fields_check(self) -> bool {
-        self.code == LuaLspOptimizationCode::SkipTableFieldsCheck
-    }
-
     pub fn is_delayed_definition(self) -> bool {
         self.code == LuaLspOptimizationCode::DelayedDefinition
     }
@@ -408,20 +399,4 @@ mod tests {
             LuaLspOptimizationCode::DelayedDefinition
         );
     }
-
-    #[test]
-    fn lsp_optimization_accepts_skip_table_fields_check_aliases() {
-        for code in ["skip_table_fields_check", "check_table_field"] {
-            let attribute = LuaAttributeUse::new(
-                LuaTypeDeclId::global("lsp_optimization"),
-                vec![("code".into(), Some(doc_string(code)))],
-            );
-
-            let lsp_optimization = attribute.as_lsp_optimization().unwrap();
-            assert_eq!(
-                lsp_optimization.code,
-                LuaLspOptimizationCode::SkipTableFieldsCheck
-            );
-        }
-    }
 }

crates/emmylua_code_analysis/src/diagnostic/checker/assign_type_mismatch.rs

@@ -2,14 +2,14 @@ use std::ops::Deref;
 
 use emmylua_parser::{
     LuaAssignStat, LuaAst, LuaAstNode, LuaAstToken, LuaExpr, LuaIndexExpr, LuaLocalStat,
-    LuaNameExpr, LuaSyntaxNode, LuaSyntaxToken, LuaTableExpr, LuaVarExpr,
+    LuaNameExpr, LuaTableExpr, LuaVarExpr,
 };
 use rowan::{NodeOrToken, TextRange};
 
 use crate::{
-    DbIndex, DiagnosticCode, LuaBuiltinAttributeKind, LuaDeclExtra, LuaDeclId, LuaMemberKey,
-    LuaSemanticDeclId, LuaType, SemanticDeclLevel, SemanticModel, TypeCheckFailReason,
-    TypeCheckResult, VariadicType, get_real_type, infer_index_expr,
+    DbIndex, DiagnosticCode, LuaDeclExtra, LuaDeclId, LuaMemberKey, LuaSemanticDeclId, LuaType,
+    SemanticDeclLevel, SemanticModel, TypeCheckFailReason, TypeCheckResult, VariadicType,
+    get_real_type, infer_index_expr,
 };
 
 use super::{Checker, DiagnosticContext, humanize_lint_type};
@@ -117,13 +117,7 @@ fn check_name_expr(
         false,
     );
     if let Some(expr) = expr {
-        check_table_expr(
-            context,
-            semantic_model,
-            NodeOrToken::Node(name_expr.syntax().clone()),
-            &expr,
-            source_type.as_ref(),
-        );
+        check_table_expr(context, semantic_model, &expr, source_type.as_ref());
     }
 
     Some(())
@@ -157,13 +151,7 @@ fn check_index_expr(
         true,
     );
     if let Some(expr) = expr {
-        check_table_expr(
-            context,
-            semantic_model,
-            NodeOrToken::Node(index_expr.syntax().clone()),
-            &expr,
-            source_type.as_ref(),
-        );
+        check_table_expr(context, semantic_model, &expr, source_type.as_ref());
     }
     Some(())
 }
@@ -200,13 +188,7 @@ fn check_local_stat(
             false,
         );
         if let Some(expr) = value_exprs.get(idx) {
-            check_table_expr(
-                context,
-                semantic_model,
-                NodeOrToken::Node(var.syntax().clone()),
-                expr,
-                Some(&var_type),
-            );
+            check_table_expr(context, semantic_model, expr, Some(&var_type));
         }
     }
     Some(())
@@ -216,27 +198,9 @@ fn check_local_stat(
 pub fn check_table_expr(
     context: &mut DiagnosticContext,
     semantic_model: &SemanticModel,
-    decl_node: NodeOrToken<LuaSyntaxNode, LuaSyntaxToken>,
     table_expr: &LuaExpr,
     table_type: Option<&LuaType>, // 记录的类型
 ) -> Option<bool> {
-    // 检查是否附加了元数据以跳过诊断
-    if let Some(semantic_decl) = semantic_model.find_decl(decl_node, SemanticDeclLevel::default()) {
-        if let Some(property) = semantic_model
-            .get_db()
-            .get_property_index()
-            .get_property(&semantic_decl)
-        {
-            if property
-                .find_builtin_attribute(LuaBuiltinAttributeKind::LspOptimization)
-                .and_then(|attribute_use| attribute_use.as_lsp_optimization())
-                .is_some_and(|attribute| attribute.is_skip_table_fields_check())
-            {
-                return Some(false);
-            }
-        }
-    }
-
     let table_type = table_type?;
     let Some(table_expr) = LuaTableExpr::cast(table_expr.syntax().clone()) else {
         return Some(false);

crates/emmylua_code_analysis/src/diagnostic/checker/missing_fields.rs

@@ -1,12 +1,8 @@
 use hashbrown::{HashMap, HashSet};
 
-use emmylua_parser::{LuaAst, LuaAstNode, LuaExpr, LuaSyntaxId, LuaTableExpr};
-use rowan::NodeOrToken;
+use emmylua_parser::{LuaAstNode, LuaExpr, LuaTableExpr};
 
-use crate::{
-    DbIndex, DiagnosticCode, LuaBuiltinAttributeKind, LuaMemberOwner, LuaType, SemanticDeclLevel,
-    SemanticModel,
-};
+use crate::{DbIndex, DiagnosticCode, LuaMemberOwner, LuaType, SemanticModel};
 
 use super::{Checker, DiagnosticContext, humanize_lint_type};
 use itertools::Itertools;
@@ -24,22 +20,7 @@ impl Checker for MissingFieldsChecker {
 
         let mut required_fields_cache = HashMap::new();
         let mut optional_field_type_cache = HashMap::new();
-        let mut skipped_table_exprs: HashSet<LuaSyntaxId> = HashSet::new();
         for expr in root.descendants::<LuaTableExpr>() {
-            let expr_syntax_id = expr.get_syntax_id();
-            if skipped_table_exprs.contains(&expr_syntax_id) {
-                continue;
-            }
-
-            if table_expr_has_skip_table_fields_check_optimization(semantic_model, &expr) {
-                skipped_table_exprs.insert(expr_syntax_id);
-                skipped_table_exprs.extend(
-                    expr.descendants::<LuaTableExpr>()
-                        .map(|expr| expr.get_syntax_id()),
-                );
-                continue;
-            }
-
             check_table_expr(
                 context,
                 semantic_model,
@@ -160,61 +141,6 @@ fn check_table_expr(
     Some(())
 }
 
-fn table_expr_has_skip_table_fields_check_optimization(
-    semantic_model: &SemanticModel,
-    expr: &LuaTableExpr,
-) -> bool {
-    let Some(parent) = expr.syntax().parent().and_then(LuaAst::cast) else {
-        return false;
-    };
-
-    let decl_node = match parent {
-        LuaAst::LuaLocalStat(local) => {
-            let Some(idx) = local
-                .get_value_exprs()
-                .position(|value| value.get_position() == expr.get_position())
-            else {
-                return false;
-            };
-            let Some(local_name) = local.get_local_name_list().nth(idx) else {
-                return false;
-            };
-            NodeOrToken::Node(local_name.syntax().clone())
-        }
-        LuaAst::LuaAssignStat(assign) => {
-            let (vars, exprs) = assign.get_var_and_expr_list();
-            let Some(idx) = exprs
-                .iter()
-                .position(|value| value.get_position() == expr.get_position())
-            else {
-                return false;
-            };
-            let Some(var) = vars.get(idx) else {
-                return false;
-            };
-            NodeOrToken::Node(var.syntax().clone())
-        }
-        _ => return false,
-    };
-
-    let Some(semantic_decl) = semantic_model.find_decl(decl_node, SemanticDeclLevel::default())
-    else {
-        return false;
-    };
-    let Some(property) = semantic_model
-        .get_db()
-        .get_property_index()
-        .get_property(&semantic_decl)
-    else {
-        return false;
-    };
-
-    property
-        .find_builtin_attribute(LuaBuiltinAttributeKind::LspOptimization)
-        .and_then(|attribute_use| attribute_use.as_lsp_optimization())
-        .is_some_and(|attribute| attribute.is_skip_table_fields_check())
-}
-
 fn get_required_fields<'a>(
     db: &DbIndex,
     table_type: &LuaType,

crates/emmylua_code_analysis/src/diagnostic/checker/param_check/type_mismatch.rs

@@ -1,7 +1,7 @@
 use std::sync::Arc;
 
 use emmylua_parser::{LuaAstNode, LuaAstToken, LuaCallExpr};
-use rowan::{NodeOrToken, TextRange};
+use rowan::TextRange;
 
 use crate::{
     DiagnosticCode, LuaFunctionType, LuaType, RenderLevel, SemanticModel, TypeCheckFailReason,
@@ -72,13 +72,8 @@ pub(super) fn check_param_types(
         if failed_arg.typ.is_table()
             && let Some(arg_expr_idx) = failed_arg.expr_index
             && let Some(arg_expr) = facts.arg_exprs.get(arg_expr_idx)
-            && let Some(add_diagnostic) = check_table_expr(
-                context,
-                semantic_model,
-                NodeOrToken::Node(arg_expr.syntax().clone()),
-                arg_expr,
-                Some(&param_type),
-            )
+            && let Some(add_diagnostic) =
+                check_table_expr(context, semantic_model, arg_expr, Some(&param_type))
             && add_diagnostic
         {
             return Some(());

crates/emmylua_code_analysis/src/diagnostic/checker/return_type_mismatch.rs

@@ -91,13 +91,7 @@ fn check_return_stat(
                     if return_expr_type.is_table()
                         && let Some(return_expr) = return_exprs.get(index)
                     {
-                        check_table_expr(
-                            context,
-                            semantic_model,
-                            NodeOrToken::Node(return_expr.syntax().clone()),
-                            return_expr,
-                            Some(check_type),
-                        );
+                        check_table_expr(context, semantic_model, return_expr, Some(check_type));
                     }
 
                     add_type_check_diagnostic(
@@ -129,13 +123,9 @@ fn check_return_stat(
                     && let Some(return_expr) = return_exprs.first()
                 {
                     // 表字段已经报错了, 则不添加返回值不匹配的诊断避免干扰
-                    if let Some(add_diagnostic) = check_table_expr(
-                        context,
-                        semantic_model,
-                        NodeOrToken::Node(return_expr.syntax().clone()),
-                        return_expr,
-                        Some(return_type),
-                    ) && add_diagnostic
+                    if let Some(add_diagnostic) =
+                        check_table_expr(context, semantic_model, return_expr, Some(return_type))
+                        && add_diagnostic
                     {
                         return Some(());
                     }

crates/emmylua_code_analysis/src/diagnostic/test/missing_fields_test.rs

@@ -338,27 +338,6 @@ foo({})
         ));
     }
 
-    #[test]
-    fn test_lsp_optimization_skip_table_fields_check_skips_missing_fields() {
-        let mut ws = VirtualWorkspace::new_with_init_std_lib();
-        assert!(ws.has_no_diagnostic(
-            DiagnosticCode::MissingFields,
-            r#"
-            ---@class D32.Child
-            ---@field name string
-
-            ---@class D32.Config
-            ---@field child D32.Child
-
-            ---@[lsp_optimization("skip_table_fields_check")]
-            ---@type D32.Config
-            local config = {
-                child = {},
-            }
-        "#
-        ));
-    }
-
     #[test]
     fn test_call_argument_comment_does_not_shift_missing_fields_range() {
         let mut ws = VirtualWorkspace::new();

crates/emmylua_ls/std_i18n/builtin/zh_CN.yaml

@@ -86,7 +86,6 @@ lsp_optimization: |
 
   ### 参数
 
-  - `skip_table_fields_check`: 跳过表字段诊断。建议对所有大型配置表使用此选项。
   - `delayed_definition`: 表示变量类型由第一次赋值决定，仅对没有初始值的 `local` 声明有效。
 
 index_alias: |