update hover function

感觉需要重构, 太臃肿了

Author: xuhuanzy

crates/emmylua_ls/src/handlers/definition/goto_function.rs

@@ -173,7 +173,8 @@ fn handle_signature_match(
     }
 }
 
-fn extract_semantic_decl_from_signature(
+/// 从函数签名中提取其定义的语义ID
+pub fn extract_semantic_decl_from_signature(
     compilation: &LuaCompilation,
     signature_id: &LuaSignatureId,
 ) -> Option<LuaSemanticDeclId> {

crates/emmylua_ls/src/handlers/definition/mod.rs

@@ -20,6 +20,7 @@ use rowan::TokenAtOffset;
 use tokio_util::sync::CancellationToken;
 
 use crate::context::ServerContextSnapshot;
+pub use goto_function::extract_semantic_decl_from_signature;
 
 use super::RegisterCapabilities;
 

crates/emmylua_ls/src/handlers/hover/function_humanize.rs

@@ -7,12 +7,15 @@ use emmylua_code_analysis::{
 };
 use emmylua_parser::{LuaAstNode, LuaDocTagField, LuaDocType};
 
-use crate::handlers::hover::{
-    hover_humanize::{
-        extract_description_from_property_owner, extract_owner_name_from_element,
-        hover_humanize_type, DescriptionInfo,
+use crate::handlers::{
+    definition::extract_semantic_decl_from_signature,
+    hover::{
+        hover_humanize::{
+            extract_description_from_property_owner, extract_owner_name_from_element,
+            hover_humanize_type, DescriptionInfo,
+        },
+        infer_prefix_global_name, HoverBuilder,
     },
-    infer_prefix_global_name, HoverBuilder,
 };
 
 #[derive(Debug, Clone)]
@@ -87,6 +90,41 @@ pub fn hover_function_type(
             _ => None,
         };
 
+        // 如果函数定义来自于其他文件, 我们需要添加原始的注释信息. 参考`test_other_file_function`
+        if let LuaType::Signature(signature_id) = typ {
+            if let Some(semantic_id) =
+                extract_semantic_decl_from_signature(builder.compilation, &signature_id)
+            {
+                if semantic_id != *semantic_decl_id {
+                    // signature 的原始定义的描述信息
+                    if let Some(origin_description) = extract_description_from_property_owner(
+                        &builder.semantic_model,
+                        &semantic_id,
+                    ) {
+                        match &mut function_info.description {
+                            Some(current_description) => {
+                                // 如果描述不为空, 则合并描述
+                                if let Some(description) = origin_description.description {
+                                    if current_description.description.is_none() {
+                                        current_description.description = Some(description);
+                                    } else {
+                                        current_description.description = Some(format!(
+                                            "{}\n{}",
+                                            current_description.description.take()?,
+                                            description
+                                        ));
+                                    }
+                                }
+                            }
+                            None => {
+                                function_info.description = Some(origin_description);
+                            }
+                        }
+                    }
+                }
+            }
+        }
+
         // 如果当前类型是 Union，传入已处理的类型集合
         let result = match typ {
             LuaType::Union(_) => process_single_function_type_with_exclusions(

crates/emmylua_ls/src/handlers/test/hover_function_test.rs

@@ -426,4 +426,27 @@ mod tests {
             },
         ));
     }
+    #[test]
+    fn test_other_file_function() {
+        let mut ws = ProviderVirtualWorkspace::new();
+        ws.def_file(
+            "a.lua",
+            r#"
+            ---测试
+            local function zipLatest(...)
+            end
+            return zipLatest
+
+            "#,
+        );
+        assert!(ws.check_hover(
+            r#"
+                local zipLatest = require("a")
+                <??>zipLatest()
+            "#,
+            VirtualHoverResult {
+                value: "```lua\nlocal function zipLatest(...)\n```\n\n---\n\n测试".to_string(),
+            },
+        ));
+    }
 }