Fix #289

Author: CppCXY

crates/emmylua_code_analysis/src/db_index/member/lua_member_item.rs

@@ -14,7 +14,7 @@ impl LuaMemberIndexItem {
     }
 
     pub fn resolve_semantic_decl(&self, db: &DbIndex) -> Option<LuaSemanticDeclId> {
-        resolve_member_property(db, &self)
+        resolve_member_semantic_id(db, &self)
     }
 
     pub(super) fn resolve_member_id(&self, member_index: &LuaMemberIndex) -> Option<LuaMemberId> {
@@ -177,7 +177,7 @@ enum MemberTypeResolveState {
     FileDecl,
 }
 
-fn resolve_member_property(
+fn resolve_member_semantic_id(
     db: &DbIndex,
     member_item: &LuaMemberIndexItem,
 ) -> Option<LuaSemanticDeclId> {
@@ -201,14 +201,20 @@ fn resolve_member_property(
 
             match resolve_state {
                 MemberSemanticDeclResolveState::MetaOrNone => {
+                    let mut last_valid_member =
+                        LuaSemanticDeclId::Member(members.first()?.get_id());
                     for member in &members {
                         let feature = member.get_feature();
                         if feature.is_meta_decl() {
-                            return Some(LuaSemanticDeclId::Member(member.get_id()));
+                            let semantic_id = LuaSemanticDeclId::Member(member.get_id());
+                            last_valid_member = semantic_id.clone();
+                            if check_member_version(db, semantic_id.clone()) {
+                                return Some(semantic_id);
+                            }
                         }
                     }
 
-                    Some(LuaSemanticDeclId::Member(members.first()?.get_id()))
+                    Some(last_valid_member)
                 }
                 MemberSemanticDeclResolveState::FirstDefine => {
                     for member in &members {
@@ -241,3 +247,16 @@ enum MemberSemanticDeclResolveState {
     FirstDefine,
     FileDecl,
 }
+
+fn check_member_version(db: &DbIndex, semantic_id: LuaSemanticDeclId) -> bool {
+    let Some(property) = db.get_property_index().get_property(&semantic_id) else {
+        return true;
+    };
+
+    if let Some(version) = &property.version_conds {
+        let version_number = db.get_emmyrc().runtime.version.to_lua_version_number();
+        return version.iter().any(|cond| cond.check(&version_number));
+    }
+
+    true
+}

crates/emmylua_code_analysis/src/db_index/semantic_decl.rs

@@ -8,6 +8,7 @@ pub enum LuaSemanticDeclId {
     Member(LuaMemberId),
     LuaDecl(LuaDeclId),
     Signature(LuaSignatureId),
+    // Multi(Box<Vec<LuaSemanticDeclId>>),
 }
 
 impl From<LuaDeclId> for LuaSemanticDeclId {

crates/emmylua_code_analysis/src/diagnostic/checker/access_invisible.rs

@@ -47,7 +47,7 @@ fn check_name_expr(
     }
 
     let name_token = name_expr.get_name_token()?;
-    if !semantic_model.is_property_visible(name_token.syntax().clone(), semantic_decl.clone()) {
+    if !semantic_model.is_semantic_visible(name_token.syntax().clone(), semantic_decl.clone()) {
         let emmyrc = semantic_model.get_emmyrc();
         report_reason(context, &emmyrc, name_token.get_range(), semantic_decl);
     }
@@ -71,7 +71,7 @@ fn check_index_expr(
     }
 
     let index_token = index_expr.get_index_name_token()?;
-    if !semantic_model.is_property_visible(index_token.clone(), semantic_decl.clone()) {
+    if !semantic_model.is_semantic_visible(index_token.clone(), semantic_decl.clone()) {
         let emmyrc = semantic_model.get_emmyrc();
         report_reason(context, &emmyrc, index_token.text_range(), semantic_decl);
     }

crates/emmylua_code_analysis/src/diagnostic/test/access_invisible_test.rs

@@ -0,0 +1,21 @@
+#[cfg(test)]
+mod tests {
+    use crate::{DiagnosticCode, Emmyrc, EmmyrcLuaVersion, VirtualWorkspace};
+
+    #[test]
+    fn test_issue_289() {
+        let mut ws = VirtualWorkspace::new();
+        let mut config = Emmyrc::default();
+        config.runtime.version = EmmyrcLuaVersion::LuaJIT;
+        ws.analysis.update_config(config.into());
+        assert!(ws.check_code_for_namespace(
+            DiagnosticCode::AccessInvisible,
+            r#"
+            local file = io.open("test.txt", "r")
+            if file then
+                file:close()
+            end
+            "#
+        ));
+    }
+}

crates/emmylua_code_analysis/src/diagnostic/test/mod.rs

@@ -1,3 +1,4 @@
+mod access_invisible_test;
 mod assign_type_mismatch_test;
 mod await_in_sync_test;
 mod check_return_count_test;

crates/emmylua_code_analysis/src/semantic/mod.rs

@@ -205,7 +205,7 @@ impl<'a> SemanticModel<'a> {
         .unwrap_or(false)
     }
 
-    pub fn is_property_visible(
+    pub fn is_semantic_visible(
         &self,
         token: LuaSyntaxToken,
         property_owner: LuaSemanticDeclId,

crates/emmylua_ls/src/handlers/completion/add_completions/mod.rs

@@ -23,7 +23,7 @@ pub fn check_visibility(builder: &mut CompletionBuilder, id: LuaSemanticDeclId)
 
     if !builder
         .semantic_model
-        .is_property_visible(builder.trigger_token.clone(), id)
+        .is_semantic_visible(builder.trigger_token.clone(), id)
     {
         return None;
     }