test: make diagnostic helper name match behavior

Rename check_code_for to has_no_diagnostic so assertions describe the
existing behavior directly.

Assisted-by: Codex

Author: lewis6991

crates/emmylua_code_analysis/src/compilation/test/and_or_test.rs

@@ -6,7 +6,7 @@ mod test {
     fn test_issue_221() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::NeedCheckNil,
             r#"
         --- @param opts table|nil
@@ -30,7 +30,7 @@ mod test {
     fn test_issue_222() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::AssignTypeMismatch,
             r#"
             local a --- @type boolean
@@ -111,7 +111,7 @@ mod test {
     fn test_issue_482() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::AssignTypeMismatch,
             r#"
             local command_provider --- @type {commands: string[]}?
@@ -126,7 +126,7 @@ mod test {
     fn test_issue_644() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::NeedCheckNil,
             r#"
             --- @alias mapfn fun()

crates/emmylua_code_analysis/src/compilation/test/annotation_test.rs

@@ -6,7 +6,7 @@ mod test {
     fn test_issue_223() {
         let mut ws = VirtualWorkspace::new_with_init_std_lib();
 
-        ws.check_code_for(
+        ws.has_no_diagnostic(
             DiagnosticCode::ReturnTypeMismatch,
             r#"
         --- @return integer
@@ -117,7 +117,7 @@ mod test {
     fn test_generic_type_inference() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(!ws.check_code_for(
+        assert!(!ws.has_no_diagnostic(
             DiagnosticCode::TypeNotFound,
             r#"
             ---@class AnonymousObserver<T>: Observer<T>
@@ -129,7 +129,7 @@ mod test {
     fn test_class_super_cycle_filters_query_supers() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(!ws.check_code_for(
+        assert!(!ws.has_no_diagnostic(
             DiagnosticCode::CircleDocClass,
             r#"
             ---@class ClassCycleA: ClassCycleB
@@ -142,7 +142,7 @@ mod test {
     fn test_generic_class_super_cycle_reports_diagnostic() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(!ws.check_code_for(
+        assert!(!ws.has_no_diagnostic(
             DiagnosticCode::CircleDocClass,
             r#"
             ---@class GenericCycleA<T>: GenericCycleB<T>
@@ -322,7 +322,7 @@ mod test {
     fn test_type_return_usage() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::AnnotationUsageError,
             r#"
             ---@type string

crates/emmylua_code_analysis/src/compilation/test/array_test.rs

@@ -22,7 +22,7 @@ mod test {
         "#,
         );
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::NeedCheckNil,
             r#"
                 local a = items[index]
@@ -54,7 +54,7 @@ mod test {
     #[test]
     fn test_array_for_flow() {
         let mut ws = VirtualWorkspace::new();
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::NeedCheckNil,
             r#"
         --- @param _x string

crates/emmylua_code_analysis/src/compilation/test/attribute_test.rs

@@ -33,7 +33,7 @@ mod test {
     fn test_def_attribute() {
         let mut ws = VirtualWorkspace::new_with_init_std_lib();
 
-        ws.check_code_for(
+        ws.has_no_diagnostic(
             DiagnosticCode::AssignTypeMismatch,
             r#"
         ---@[lsp_optimization("check_table_field")]

crates/emmylua_code_analysis/src/compilation/test/closure_generic.rs

@@ -6,7 +6,7 @@ mod test {
     fn test_generic() {
         let mut ws = VirtualWorkspace::new_with_init_std_lib();
 
-        ws.check_code_for(
+        ws.has_no_diagnostic(
             DiagnosticCode::TypeNotFound,
             r#"
         --- @generic T

crates/emmylua_code_analysis/src/compilation/test/closure_return_test.rs

@@ -43,7 +43,7 @@ mod test {
     fn test_issue_265() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::ReturnTypeMismatch,
             r#"
         local function bar()
@@ -62,7 +62,7 @@ mod test {
     #[test]
     fn test_issue_464() {
         let mut ws = VirtualWorkspace::new();
-        assert!(!ws.check_code_for_namespace(
+        assert!(!ws.has_no_diagnostic_in_namespace(
             DiagnosticCode::ReturnTypeMismatch,
             r#"
                 ---@class D31
@@ -77,7 +77,7 @@ mod test {
         "#,
         ));
 
-        assert!(ws.check_code_for_namespace(
+        assert!(ws.has_no_diagnostic_in_namespace(
             DiagnosticCode::ReturnTypeMismatch,
             r#"
                 ---@class D31

crates/emmylua_code_analysis/src/compilation/test/decl_test.rs

@@ -41,7 +41,7 @@ mod test {
     #[test]
     fn test_3() {
         let mut ws = VirtualWorkspace::new();
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::ParamTypeMismatch,
             r#"
                 ---@return any ...

crates/emmylua_code_analysis/src/compilation/test/diagnostic_disable_test.rs

@@ -6,7 +6,7 @@ mod test {
     fn test_disable_nextline() {
         let mut ws = VirtualWorkspace::new();
 
-        assert!(ws.check_code_for(
+        assert!(ws.has_no_diagnostic(
             DiagnosticCode::SyntaxError,
             r#"
         ---@diagnostic disable-next-line: syntax-error