fix LuaJIT name in warnings#1172
Conversation
emmylua_check usually misspells LuaJIT name in warnings. The patch fixes that. Closes EmmyLuaLs#1170
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Issue Identified
Inconsistent naming convention - The change modifies the display output for LuaVersionNumber::LUA_JIT from "Lua JIT" to "LuaJIT".
Analysis
This is a minor cosmetic change that affects how the LuaJIT version is displayed. The change removes the space between "Lua" and "JIT", making it a single word "LuaJIT".
Recommendation
While this change is functionally safe, consider:
- Consistency check: Ensure this new format aligns with how LuaJIT is referred to in other parts of the codebase (documentation, error messages, etc.)
- Backward compatibility: If this display string is used in any serialization or parsing logic, this change could break existing functionality
- Official naming: LuaJIT's official name is typically written as "LuaJIT" (no space), so this change is actually more accurate
Verdict
Approved - This is a low-risk change that improves accuracy of the display name. No security or logical issues detected.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Display implementation for LuaVersionNumber to format LuaVersionNumber::LUA_JIT as "LuaJIT" instead of "Lua JIT". There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
emmylua_check usually misspells LuaJIT name in warnings. The patch fixes that.
Closes #1170