canonicalize file path before check excluding#569
Closed
tinyleolin wants to merge 1 commit into
Closed
Conversation
Member
|
Contributor
Author
|
对第一点有什么建议吗 |
Member
|
不要支持相对路径 |
Contributor
Author
|
通常项目配置都是以相对路径方式配置的吧，除非是引用的第三方库，你的最佳实践是什么呢 |
Member
|
默认情况下, 整个路径是相对于主工作区的, 我反对的是在路径中使用 另外如果如果相关文件在工作区外面, 那么应该使用绝对路径指向它而不是使用 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #551