Skip to content

Add gst_video_sync integration test#408

Open
mvollrath wants to merge 1 commit into
masterfrom
test_gst_video_sync
Open

Add gst_video_sync integration test#408
mvollrath wants to merge 1 commit into
masterfrom
test_gst_video_sync

Conversation

@mvollrath
Copy link
Copy Markdown
Member

No description provided.

rospy.sleep(1)

with self.assertRaises(subprocess.CalledProcessError):
subprocess.check_call([
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subprocess call - check for execution of untrusted input.

rospy.sleep(1)

with self.assertRaises(subprocess.CalledProcessError):
subprocess.check_call([
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting a process with a partial executable path

self.scene_pub.publish(GenericMessage(type='json', message=json.dumps(scene)))
rospy.sleep(1)

subprocess.check_call([
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subprocess call - check for execution of untrusted input.

self.scene_pub.publish(GenericMessage(type='json', message=json.dumps(scene)))
rospy.sleep(1)

subprocess.check_call([
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting a process with a partial executable path

import unittest
import rospy
import json
import subprocess
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider possible security implications associated with subprocess module.

@sourcelevel-bot
Copy link
Copy Markdown

SourceLevel has finished reviewing this Pull Request and has found:

  • 416 possible new issues (including those that may have been commented here).
  • 189 fixed issues! 🎉

But beware that this branch is 41 commits behind the EndPointCorp:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://app.sourcelevel.io/github/EndPointCorp/lg_ros_nodes/pulls/408.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant